Branch: refs/heads/main
Revision: 915d618359e9ca8bf06cd5081e0f35767a1b9c4b
Author: Elliot Ronaghan
Link: Use pkg-config for zmq package tests by ronawho · Pull Request #21026 · chapel-lang/chapel · GitHub
Log Message:
Use pkg-config for zmq package tests
Previously, the ZMQ package tests required a system install of libzmq to work. Our skipif would look for a libzmq library and if it was found assume that a zmq.h header would be found too. However, this isn't always the case and we have systems that have the libzmq library but not the headers, which caused the tests to run and then fail. To improve this, use pkg-config to check if zmq is installed and to get appropriate compilation cflags/libs. We've run into the zmq library only issue before and added a workaround in #20191 that let us manually skip the tests, but this makes that check automatic, at least for the package tests. We'll want to do something similar for the multi-locale interop tests at some point too, but I think that will require updating the compiler or makefile makefile support for mli to use pkg-config to get cflags/libs.) Tested start_test --respect-skipifs test/library/packages/ZMQ/ on - machine with system libzmq.so and zmq.h (passed) - machine with spack installed zmq (passed) - machine with brew installed zmq (passed) - machine with only libzmq.so and not zmq.h (skipped) Motivated by Cray/chapel-private#4011
Compare: Comparing ee492a0fa4b155535d4af81651c8c2ba4d665289...915d618359e9ca8bf06cd5081e0f35767a1b9c4b · chapel-lang/chapel · GitHub
Diff: https://github.com/chapel-lang/chapel/pull/21026.diff
Modified Files:
modules/dists/BlockDist.chpl,modules/internal/DefaultRectangular.chpl,test/library/packages/ZMQ.skipif,test/library/packages/ZMQ/getLastEndpointMain.preexec,test/library/packages/ZMQ/version.prediff
Added Files:
test/library/packages/ZMQ/COMPOPTS,test/library/packages/ZMQ/interop-py/COMPOPTS,test/library/packages/ZMQ/multilocale/COMPOPTS
Removed Files: