Branch: refs/heads/main
Revision: 5bdc0a4
Author: bradcray
Link: Try renaming err_t to qio_err_t to avoid conflicts with AMD math library by bradcray · Pull Request #19703 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19703 from bradcray/rename-err_t
Try renaming err_t to qio_err_t to avoid conflicts with AMD math library
[reviewed by @mppf]
On Discourse,
a user noted that they were unable to build Chapel against the AMD math library
because we use err_t in our runtime as a type alias for errors from QIO, and
the AMD math library uses that identifier as well. This PR changes the symbol to
qio_err_t to eliminate this conflict and reduce the chances of conflict with other
C headers.
Modified Files:
M modules/packages/Socket.chpl
M modules/standard/IO.chpl
M modules/standard/Sys.chpl
M modules/standard/SysBasic.chpl
M modules/standard/SysError.chpl
M runtime/include/qio/qio.h
M runtime/include/qio/qio_error.h
M runtime/include/qio/sys.h
M runtime/src/qio/qbuffer.c
M runtime/src/qio/qio.c
M runtime/src/qio/qio_formatted.c
M runtime/src/qio/sys.c
Compare: https://github.com/chapel-lang/chapel/compare/60b31a68ba5c...5bdc0a45a44d