Branch: refs/heads/main
Revision: a5c847d
Author: mppf
Link: Tidy up dyno C++ tests by mppf · Pull Request #20828 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #20828 from mppf/dyno-tests-updates
Tidy up dyno C++ tests
This PR was motivated by my observation that these C++ tests were
building with a mix of assertions enabled and disabled. That's due to the
way that some headers were included before #undef NDEBUG. But, we want
these C++ tests to always run with assertions on.
This PR improves the situation by adding test-common.h which does the
#undef NDEBUG and arranges for this to always be the first thing
included (possibly by another header) from one of these tests. It splits
the helper functions & using declarations into test-parsing.h and
test-resolution.h and corresponding .cpp files. test-parsing.h and
test-resolution.h start by including test-common.h so assertions will
be enabled as long as a test starts with one of these 3 headers.
This PR also fixes an issue with cmake when CHPL_LLVM_LINK_ARGS is
blank.
Reviewed by @DanilaFe - thanks!
Modified Files:
A frontend/test/test-common.h
A frontend/test/test-parsing.cpp
A frontend/test/test-parsing.h
A frontend/test/test-resolution.cpp
A frontend/test/test-resolution.h
R frontend/test/common.cpp
R frontend/test/common.h
M frontend/CMakeLists.txt
M frontend/test/CMakeLists.txt
M frontend/test/framework/testDependencies.cpp
M frontend/test/framework/testIds.cpp
M frontend/test/framework/testRecursionFails.cpp
M frontend/test/framework/testUniqueString.cpp
M frontend/test/parsing/testParse.cpp
M frontend/test/parsing/testParseAggregate.cpp
M frontend/test/parsing/testParseArrayDomainRange.cpp
M frontend/test/parsing/testParseAttributes.cpp
M frontend/test/parsing/testParseBegin.cpp
M frontend/test/parsing/testParseBracketLoop.cpp
M frontend/test/parsing/testParseChecks.cpp
M frontend/test/parsing/testParseCobegin.cpp
M frontend/test/parsing/testParseCoforall.cpp
M frontend/test/parsing/testParseComments.cpp
M frontend/test/parsing/testParseConditional.cpp
M frontend/test/parsing/testParseDefer.cpp
M frontend/test/parsing/testParseDelete.cpp
M frontend/test/parsing/testParseDoWhile.cpp
M frontend/test/parsing/testParseEmptyStmt.cpp
M frontend/test/parsing/testParseEnums.cpp
M frontend/test/parsing/testParseFor.cpp
M frontend/test/parsing/testParseForall.cpp
M frontend/test/parsing/testParseForeach.cpp
M frontend/test/parsing/testParseForwardingDecl.cpp
M frontend/test/parsing/testParseFunctions.cpp
M frontend/test/parsing/testParseImport.cpp
M frontend/test/parsing/testParseInclude.cpp
M frontend/test/parsing/testParseInterface.cpp
M frontend/test/parsing/testParseLabelContinueBreak.cpp
M frontend/test/parsing/testParseLocal.cpp
M frontend/test/parsing/testParseModuleInclude.cpp
M frontend/test/parsing/testParseModules.cpp
M frontend/test/parsing/testParseMultiVar.cpp
M frontend/test/parsing/testParseNew.cpp
M frontend/test/parsing/testParseNumericLiterals.cpp
M frontend/test/parsing/testParseOn.cpp
M frontend/test/parsing/testParseReturn.cpp
M frontend/test/parsing/testParseSelect.cpp
M frontend/test/parsing/testParseSerial.cpp
M frontend/test/parsing/testParseStringBytesLiterals.cpp
M frontend/test/parsing/testParseSync.cpp
M frontend/test/parsing/testParseTryCatchThrow.cpp
M frontend/test/parsing/testParseTupleVar.cpp
M frontend/test/parsing/testParseUse.cpp
M frontend/test/parsing/testParseVariables.cpp
M frontend/test/parsing/testParseWhile.cpp
M frontend/test/parsing/testParseYield.cpp
M frontend/test/parsing/testParsingQueries.cpp
M frontend/test/resolution/testCanPass.cpp
M frontend/test/resolution/testClasses.cpp
M frontend/test/resolution/testDisambiguation.cpp
M frontend/test/resolution/testEnums.cpp
M frontend/test/resolution/testExprIf.cpp
M frontend/test/resolution/testFieldAccess.cpp
M frontend/test/resolution/testFindDecl.cpp
M frontend/test/resolution/testFunctionCalls.cpp
M frontend/test/resolution/testGenericDefaults.cpp
M frontend/test/resolution/testInteractive.cpp
M frontend/test/resolution/testLocation.cpp
M frontend/test/resolution/testLoopIndexVars.cpp
M frontend/test/resolution/testMultiDecl.cpp
M frontend/test/resolution/testOperatorOverloads.cpp
M frontend/test/resolution/testParamFolding.cpp
M frontend/test/resolution/testParamIf.cpp
M frontend/test/resolution/testParams.cpp
M frontend/test/resolution/testPoi.cpp
M frontend/test/resolution/testProcThis.cpp
M frontend/test/resolution/testRanges.cpp
M frontend/test/resolution/testResolve.cpp
M frontend/test/resolution/testResolveMethodCalls.cpp
M frontend/test/resolution/testResolveNew.cpp
M frontend/test/resolution/testReturnTypes.cpp
M frontend/test/resolution/testScopeResolve.cpp
M frontend/test/resolution/testTaskIntents.cpp
M frontend/test/resolution/testTuples.cpp
M frontend/test/resolution/testTypeAndInit.cpp
M frontend/test/resolution/testTypeConstruction.cpp
M frontend/test/resolution/testTypeOperators.cpp
M frontend/test/resolution/testTypeQueries.cpp
M frontend/test/resolution/testVarArgs.cpp
M frontend/test/uast/testBuildIDs.cpp
M frontend/test/uast/testConsistentEnums.cpp
M frontend/test/uast/testStringify.cpp
M frontend/test/uast/testVisit.cpp
M frontend/test/util/testIteratorAdapters.cpp
M frontend/test/util/testLLVMsupport.cpp
M frontend/test/util/testQueryTimingAndTrace.cpp
M frontend/test/util/testQuoteStrings.cpp
M frontend/test/util/testSubprocess.cpp
Compare: https://github.com/chapel-lang/chapel/compare/5e64edc4853f...a5c847d33e32