Branch: refs/heads/main
Revision: f08330b
Author: jeremiah-corrado
Link: Add noMmap hint to ioHintSet by jeremiah-corrado · Pull Request #20468 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #20468 from jeremiah-corrado/iohintset-noMmap
This PR implements some changes to ioHintSet discussed in this issue: Should `ioHintSet` support additional hints as type methods? · Issue #20346 · chapel-lang/chapel · GitHub
- QIO_METHOD_PREADPWRITE was added to the ioHintSet type as a new hint called
noMmap - The undocumented ioHintSet.direct() method was renamed to ioHintSet.fromFlag() as it could conflict with the "direct" iohint if it is ever added in the future
- Switched uses of ioHintSet.direct(QIO_HINT_PARALLEL) to ioHintSet.mmap, as QIO_HINT_PARALLEL is invoked by the mmap hint
- Tests and library code were updated to reflect the above changes.
[reviewed by @lydia-duncan] - Thanks!
Modified Files:
M modules/standard/IO.chpl
M modules/standard/Subprocess.chpl
M test/io/tzakian/recordReader/test.chpl
M test/library/standard/IO/ioHintSetOperations.chpl
M test/library/standard/IO/ioHintSetOperations.good
M test/release/examples/benchmarks/shootout/revcomp-fast.chpl
M test/release/examples/benchmarks/shootout/revcomp.chpl
M test/studies/shootout/reverse-complement/bharshbarg/revcomp-begin.chpl
M test/studies/shootout/reverse-complement/bharshbarg/revcomp-buf.chpl
M test/studies/shootout/reverse-complement/bharshbarg/revcomp-line.chpl
M test/studies/shootout/reverse-complement/bharshbarg/revcomp-mark-skip-read-begin.chpl
M test/studies/shootout/reverse-complement/bradc/revcomp-blc-begin-const-ref.chpl
M test/studies/shootout/reverse-complement/bradc/revcomp-blc-begin-const-ref.verify.chpl
M test/studies/shootout/reverse-complement/bradc/revcomp-blc-begin-ref.chpl
M test/studies/shootout/reverse-complement/bradc/revcomp-blc-copyPropBug.chpl
M test/studies/shootout/reverse-complement/bradc/revcomp-blc-tpv.chpl
M test/studies/shootout/reverse-complement/bradc/revcomp-blc.chpl
M test/studies/shootout/reverse-complement/bradc/revcomp-dowhile-bug.chpl
Compare: https://github.com/chapel-lang/chapel/compare/25d82fdeef91...f08330b84e59