Branch: refs/heads/main
Revision: 1abb365
Author: vasslitvinov
Link: Switch {array,domain,distribution}.targetLocales to parenless by vasslitvinov · Pull Request #18930 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #18930 from vasslitvinov/targetLocales-parenless
Switch {array,domain,distribution}.targetLocales to parenless
This PR switches the targetLocales method on Chapel arrays, domains,
and distributions to be paren-less. It implements the decision
made by the domain module review on 6/14/21 (internal issue 2118)
and extends it to arrays and distributions for consistency.
It adjusts the compiler to emit a warning when such targetLocales
is invoked with parentheses. This was the easiest way to implement
such a warning. This adjustment should be removed after the deprecation
period.
It also adjusts modules and tests to comply with this change
and adds a test for the warning in test/deprecated.
Future work: add targetLocales to the default distribution.
r: @lydia-duncan
Modified Files:
A test/deprecated/targetLocales.chpl
A test/deprecated/targetLocales.good
M compiler/resolution/preFold.cpp
M modules/internal/ChapelArray.chpl
M modules/internal/ChapelDomain.chpl
M modules/packages/HDF5.chpl
M modules/packages/ReplicatedVar.chpl
M modules/packages/Sort.chpl
M test/arrays/ferguson/default-rectangular-targetlocales.chpl
M test/arrays/localQueries/testDROnRemoteLocale.chpl
M test/arrays/userAPI/arrayAPItest.chpl
M test/arrays/userAPI/assocArrayAPItest.chpl
M test/distributions/bharshbarg/subQuery.chpl
M test/distributions/block/remoteOwnership.chpl
M test/distributions/cyclic/remoteOwnership.chpl
M test/distributions/stencil/remoteOwnership.chpl
M test/domains/userAPI/domainAPItest.chpl
M test/domains/userAPI/test2Ddomain.good
M test/domains/userAPI/testEnumDomain.good
M test/io/diten/checkpoint.chpl
M test/library/packages/Sort/RadixSort/ips4o-like.chpl
M test/release/examples/benchmarks/ssca2/SSCA2_Modules/io_RMAT_graph.chpl
M test/release/examples/primers/distributions.chpl
M test/studies/cholesky/jglewis/version2/elemental/block_distribution/elemental_cholesky_symmetric_index_ranges_block.chpl
M test/studies/cholesky/jglewis/version2/elemental/elemental_cholesky_symmetric_index_ranges.chpl
M test/studies/cholesky/jglewis/version2/elemental/elemental_cholesky_symmetric_index_ranges_alt.chpl
M test/studies/cholesky/jglewis/version2/elemental/fully_blocked/elemental_cholesky_fully_blocked.chpl
M test/studies/cholesky/jglewis/version2/elemental/strided/elemental_cholesky_symmetric_strided.chpl
M test/studies/cholesky/jglewis/version2/elemental/unsymmetric_indices/elemental_cholesky_unsymmetric_index_ranges.chpl
M test/studies/comd/llnl/CoMD.chpl
M test/studies/hpcc/PTRANS/jglewis/ptrans_2011-blkcyc.chpl
M test/studies/hpcc/PTRANS/jglewis/ptrans_2011.chpl
M test/studies/prk/DGEMM/SUMMA/dgemm.chpl
M test/studies/stencil9/stencil9-explicit.chpl
M test/users/npadmana/npb-mg/mg.chpl
Compare: https://github.com/chapel-lang/chapel/compare/07fd754d9a94...1abb3654cef1