Branch: refs/heads/master
Revision: d399e88
Author: mppf
Log Message:
Merge pull request #16831 from mppf/fix-callstack-err1
Print callstacks for errors in inlined functions
The goal of this PR is to improve the error message for
test/domains/marybeth/test_compare_range.chpl as a follow-up to PR
#16823.
This PR adjusts the compiler error logic to print the In function
header and callstack in more cases. Previously, we weren’t printing it
for inline functions but I can’t rationalize that. There is already a
workaround for initializers for this. The behavior started in
5c147eb98e02948ec29a0b078edb484561dcca14 but hiding the function doesn’t
make sense to me - the error still occurs within the inline function -
and the user might have to fix that function.
Reviewed by @e-kayrakli - thanks!
- [x] full local testing
Modified Files:
A test/classes/generic/with-runtime-fields-errors.error.borrowed.good
A test/classes/generic/with-runtime-fields-errors.error.owned.good
A test/classes/generic/with-runtime-fields-errors.error.shared.good
A test/classes/generic/with-runtime-fields-errors.error.unmanaged.good
A test/distributions/deitz/test_distribution_syntax2.compopts
A test/io/vass/ddata-printing-warning.compopts
A test/types/single/vass/readThis.compopts
A test/types/single/vass/writeThis.compopts
A test/types/string/sungeun/c_string/write_c_string.compopts
A test/types/sync/vass/readThis.compopts
A test/types/sync/vass/writeThis.compopts
R test/classes/generic/with-runtime-fields-errors.error.good
M compiler/util/astlocs.cpp
M compiler/util/misc.cpp
M test/classes/generic/with-runtime-fields-errors.compopts
M test/classes/generic/with-runtime-types.bad
M test/distributions/deitz/test_block_representation.comm-none.good
M test/distributions/deitz/test_block_representation.compopts
M test/distributions/deitz/test_block_representation.lm-numa.good
M test/domains/marybeth/test_compare_range.good
M test/errhandling/misc/bracketForallThrowsBug.bad
M test/io/vass/ddata-printing-warning.good
M test/library/standard/Random/ferguson/rmixed-error.good
M test/library/standard/Reflection/fielderator-generic.bad
M test/optimizations/inline/directCall.good
M test/optimizations/inline/indirectCall.good
M test/param/ferguson/field-value-not-in-range.good
M test/param/ferguson/field-value-not-in-range2.good
M test/types/single/vass/readThis.good
M test/types/single/vass/writeThis.good
M test/types/string/sungeun/c_string/write_c_string.good
M test/types/sync/vass/readThis.good
M test/types/sync/vass/writeThis.good
Compare: https://github.com/chapel-lang/chapel/compare/3959059042d9...d399e8800ffd