[Chapel Merge] Fix failures in nightly testing for OFI configs

Notifications Commits
1

Branch: refs/heads/main
Revision: 0a4c5a711f0e4c99c27e283eb2bfad2c657baf77
Author: dlongnecke-cray
Link: Fix failures in nightly testing for OFI configs by dlongnecke-cray · Pull Request #28914 · chapel-lang/chapel · GitHub
Log Message:
Fix failures in nightly testing for OFI configs (#28914)

This PR tries to fix nightly testing failures in OFI configs. The issues
are centered around private broadcasting of runtime symbols.

In #28902 I refactored the private broadcasting API to support two
different strategies: the old "unified table" approach where we create a
single address table that contains both program and runtime symbols, and
a new "separated" approach where the runtime address table and program
address table are separate rather than combined dynamically.

While I adjusted the shim the runtime uses to broadcast updates to
runtime symbols, I forgot to add logic which re-computes the table index
when the comm layer is using a unified table.

TESTING

  • standard
  • COMM=gasnet
  • Build with COMM=ofi and run raCommCheck.chpl
  • Build with gasnet-asan and run fastAndIncremental.chpl

Reviewed by @benharsh. Thanks!

Compare: Comparing 2fd68e84197478bd26b23493b3f1cde34dcf4099...8816191f189e7a4faa0872fce450a1d4f7b9ca9a · chapel-lang/chapel · GitHub

Diff:
M runtime/include/chpl-comm-internal.h
M runtime/src/chpl-comm.c
https://github.com/chapel-lang/chapel/pull/28914.diff