Branch: refs/heads/main
Revision: 1199a52ffda72020f47e77dd0593643f3a4b718a
Author: Elliot Ronaghan
Link: Disable ugni MR checks when the cache is enabled by ronawho · Pull Request #21105 · chapel-lang/chapel · GitHub
Log Message:
Disable ugni MR checks when the cache is enabled
Disable memory registration extent checks when the remote cache is enabled since we've been getting some false-positives. These checks were added in #19127 and were meant to help catch subtle implementation bugs where a single RDMA transfer crossed multiple memory registration regions. Our MR extents are precise (in that they track the allocation start and end exactly) but the cache can read to the end of a page, which caused false-positives. We tried to quiet them in #19516 and #20642, but we've still been seeing errors sporadically in nightly. Reading to the end of a page is safe since the kernel's memory registration covers that so it was really just our checks being overly conservative. We could probably tighten up our checks, but given that ugni is no longer under active development I think it's ok to just disable these checks when the cache is on. Resolves Cray/chapel-private#3341
Compare: Comparing e54cef9f47dd6dad8295b08b5fc998ba981de593...1199a52ffda72020f47e77dd0593643f3a4b718a · chapel-lang/chapel · GitHub
Diff: https://github.com/chapel-lang/chapel/pull/21105.diff
Modified Files:
modules/standard/IO.chpl,runtime/src/comm/ugni/comm-ugni.c,test/io/ferguson/writefstring.chpl,test/release/examples/primers/fileIO.chpl,test/unicode/write_read_euro.chpl,third-party/gasnet/Makefile,third-party/gasnet/README,third-party/gasnet/gasnet-src/ChangeLog,third-party/gasnet/gasnet-src/Makefile.in,third-party/gasnet/gasnet-src/README,third-party/gasnet/gasnet-src/README-tools,third-party/gasnet/gasnet-src/acconfig.h,third-party/gasnet/gasnet-src/acinclude.m4,third-party/gasnet/gasnet-src/aries-conduit/Makefile.in,third-party/gasnet/gasnet-src/aries-conduit/README,third-party/gasnet/gasnet-src/aries-conduit/contrib/Makefile.in,third-party/gasnet/gasnet-src/aries-conduit/gasnet_aries.c,third-party/gasnet/gasnet-src/aries-conduit/gasnet_core.c,third-party/gasnet/gasnet-src/aries-conduit/gasnet_core_fwd.h,third-party/gasnet/gasnet-src/aries-conduit/gasnet_core_internal.h,third-party/gasnet/gasnet-src/config-aux/Makefile.in,third-party/gasnet/gasnet-src/configure,third-party/gasnet/gasnet-src/configure.in,third-party/gasnet/gasnet-src/docs/GASNet-EX.txt,third-party/gasnet/gasnet-src/docs/memory_kinds.md,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_autotune.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_autotune_internal.h,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_coll.h,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_coll_fwd.h,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_coll_internal.h,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_eager.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_hashtable.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_putget.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_reduce.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_refcoll.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_rvous.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_scratch.c,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_team.h,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_trees.c,third-party/gasnet/gasnet-src/extended-ref/gasnet_extended.h,third-party/gasnet/gasnet-src/extended-ref/gasnet_extended_common.c,third-party/gasnet/gasnet-src/extended-ref/gasnet_extended_refbarrier.c,third-party/gasnet/gasnet-src/extended-ref/vis/gasnet_refvis.c,third-party/gasnet/gasnet-src/extended-ref/vis/gasnet_vis_internal.h,third-party/gasnet/gasnet-src/gasnet_am.h,third-party/gasnet/gasnet-src/gasnet_atomic_fwd.h,third-party/gasnet/gasnet-src/gasnet_config.h.in,third-party/gasnet/gasnet-src/gasnet_diagnostic.c,third-party/gasnet/gasnet-src/gasnet_help.h,third-party/gasnet/gasnet-src/gasnet_internal.c,third-party/gasnet/gasnet-src/gasnet_internal.h,third-party/gasnet/gasnet-src/gasnet_membar.h,third-party/gasnet/gasnet-src/gasnet_mmap.c,third-party/gasnet/gasnet-src/gasnet_pshm.c,third-party/gasnet/gasnet-src/gasnet_pshm.h,third-party/gasnet/gasnet-src/gasnet_timer.h,third-party/gasnet/gasnet-src/gasnet_toolhelp.h,third-party/gasnet/gasnet-src/gasnet_tools.c,third-party/gasnet/gasnet-src/gasnet_trace.c,third-party/gasnet/gasnet-src/gasnet_trace.h,third-party/gasnet/gasnet-src/gasnetex.h,third-party/gasnet/gasnet-src/ibv-conduit/Makefile.in,third-party/gasnet/gasnet-src/ibv-conduit/README,third-party/gasnet/gasnet-src/ibv-conduit/contrib/Makefile.in,third-party/gasnet/gasnet-src/ibv-conduit/gasnet_core.c,third-party/gasnet/gasnet-src/ibv-conduit/gasnet_core_connect.c,third-party/gasnet/gasnet-src/ibv-conduit/gasnet_core_fwd.h,third-party/gasnet/gasnet-src/ibv-conduit/gasnet_core_internal.h,third-party/gasnet/gasnet-src/ibv-conduit/gasnet_core_sndrcv.c,third-party/gasnet/gasnet-src/license.txt,third-party/gasnet/gasnet-src/mpi-conduit/Makefile.in,third-party/gasnet/gasnet-src/mpi-conduit/contrib/Makefile.in,third-party/gasnet/gasnet-src/mpi-conduit/gasnet_core.c,third-party/gasnet/gasnet-src/mpi-conduit/gasnet_core_fwd.h,third-party/gasnet/gasnet-src/mpi-conduit/gasnet_core_internal.h,third-party/gasnet/gasnet-src/ofi-conduit/Makefile.am,third-party/gasnet/gasnet-src/ofi-conduit/Makefile.in,third-party/gasnet/gasnet-src/ofi-conduit/README,third-party/gasnet/gasnet-src/ofi-conduit/conduit.mak.in,third-party/gasnet/gasnet-src/ofi-conduit/contrib/Makefile.in,third-party/gasnet/gasnet-src/ofi-conduit/gasnet_core.c,third-party/gasnet/gasnet-src/ofi-conduit/gasnet_core.h,third-party/gasnet/gasnet-src/ofi-conduit/gasnet_core_fwd.h,third-party/gasnet/gasnet-src/ofi-conduit/gasnet_core_internal.h,third-party/gasnet/gasnet-src/ofi-conduit/gasnet_extended.c,third-party/gasnet/gasnet-src/ofi-conduit/gasnet_ofi.c,third-party/gasnet/gasnet-src/ofi-conduit/gasnet_ofi.h,third-party/gasnet/gasnet-src/other/Makefile-libgasnet.mak.in,third-party/gasnet/gasnet-src/other/Makefile.in,third-party/gasnet/gasnet-src/other/ammpi/Makefile.in,third-party/gasnet/gasnet-src/other/ammpi/ammpi_spmd.c,third-party/gasnet/gasnet-src/other/amudp/Makefile.in,third-party/gasnet/gasnet-src/other/amudp/README,third-party/gasnet/gasnet-src/other/amudp/amudp_const.h,third-party/gasnet/gasnet-src/other/amudp/amudp_ep.cpp,third-party/gasnet/gasnet-src/other/amudp/amudp_internal.h,third-party/gasnet/gasnet-src/other/amudp/amudp_reqrep.cpp,third-party/gasnet/gasnet-src/other/amudp/amudp_spmd.cpp,third-party/gasnet/gasnet-src/other/amudp/amudprun.c,third-party/gasnet/gasnet-src/other/amudp/socket.h,third-party/gasnet/gasnet-src/other/amx/amx_internal.c,third-party/gasnet/gasnet-src/other/check-pp.c,third-party/gasnet/gasnet-src/other/contrib/Makefile.in,third-party/gasnet/gasnet-src/other/contrib/cross-configure-cray-aries-alps,third-party/gasnet/gasnet-src/other/contrib/cross-configure-cray-aries-slurm,third-party/gasnet/gasnet-src/other/firehose/Makefile.in,third-party/gasnet/gasnet-src/other/firehose/firehose_page.c,third-party/gasnet/gasnet-src/other/firehose/firehose_region.c,third-party/gasnet/gasnet-src/other/gasnet_portable_platform.h,third-party/gasnet/gasnet-src/other/kinds/gasnet_hip.c,third-party/gasnet/gasnet-src/other/mpi-spawner/gasnet_bootstrap_mpi.c,third-party/gasnet/gasnet-src/other/pmi-spawner/gasnet_bootstrap_pmi.c,third-party/gasnet/gasnet-src/other/spawner/gasnetrun.pl,third-party/gasnet/gasnet-src/other/spawner/gasnetrun_mpi.pl,third-party/gasnet/gasnet-src/other/ssh-spawner/gasnet_bootstrap_ssh.c,third-party/gasnet/gasnet-src/other/valgrind/Makefile.in,third-party/gasnet/gasnet-src/smp-conduit/Makefile.in,third-party/gasnet/gasnet-src/smp-conduit/gasnet_core.c,third-party/gasnet/gasnet-src/smp-conduit/gasnet_core_fwd.h,third-party/gasnet/gasnet-src/smp-conduit/gasnet_core_internal.h,third-party/gasnet/gasnet-src/tests/Makefile.in,third-party/gasnet/gasnet-src/tests/test.h,third-party/gasnet/gasnet-src/tests/testalltoall.c,third-party/gasnet/gasnet-src/tests/testcudauva.c,third-party/gasnet/gasnet-src/tests/testgasnet.c,third-party/gasnet/gasnet-src/tests/testhip.c,third-party/gasnet/gasnet-src/tests/testimm.c,third-party/gasnet/gasnet-src/tests/testlarge.c,third-party/gasnet/gasnet-src/tests/testmpi.c,third-party/gasnet/gasnet-src/tests/testrand.c,third-party/gasnet/gasnet-src/tests/testreduce.c,third-party/gasnet/gasnet-src/tests/testsegment.c,third-party/gasnet/gasnet-src/tests/testsmall.c,third-party/gasnet/gasnet-src/tests/testsplit.c,third-party/gasnet/gasnet-src/tests/testteam.c,third-party/gasnet/gasnet-src/tests/testteambcast.c,third-party/gasnet/gasnet-src/tests/testthreads.c,third-party/gasnet/gasnet-src/tests/testtmpair.c,third-party/gasnet/gasnet-src/tests/testtools.c,third-party/gasnet/gasnet-src/tests/upcr-harness/external-upcxx/Makefile,third-party/gasnet/gasnet-src/tests/upcr-harness/external-upcxx/harness.conf,third-party/gasnet/gasnet-src/tests/upcr-harness/gasnet-tests/harness.conf,third-party/gasnet/gasnet-src/tests/upcr-harness/libgasnet/harness.conf,third-party/gasnet/gasnet-src/ucx-conduit/Makefile.in,third-party/gasnet/gasnet-src/ucx-conduit/README,third-party/gasnet/gasnet-src/ucx-conduit/contrib/Makefile.in,third-party/gasnet/gasnet-src/ucx-conduit/gasnet_core.c,third-party/gasnet/gasnet-src/ucx-conduit/gasnet_core_fwd.h,third-party/gasnet/gasnet-src/ucx-conduit/gasnet_core_internal.h,third-party/gasnet/gasnet-src/udp-conduit/Makefile.in,third-party/gasnet/gasnet-src/udp-conduit/README,third-party/gasnet/gasnet-src/udp-conduit/gasnet_core.c,third-party/gasnet/gasnet-src/udp-conduit/gasnet_core_fwd.h,third-party/gasnet/gasnet-src/udp-conduit/gasnet_core_internal.h,third-party/gasnet/gasnet-src/version.git
Added Files:
test/deprecated/IO/unicodeSupported.chpl,test/deprecated/IO/unicodeSupported.good,test/studies/adventOfCode/2022/README.md,test/unstable/iostyle/iostringformat.chpl,test/unstable/iostyle/iostringformat.good,test/unstable/iostyle/iostringstyle.chpl,test/unstable/iostyle/iostringstyle.good,third-party/gasnet/gasnet-src/extended-ref/coll/gasnet_bootstrap.c
Removed Files: