[Chapel Merge] Deprecate old Sort functions and replace with new argument lists

Notifications Commits
1

Branch: refs/heads/main
Revision: 7f1b74146a6b799423922a693f590b054d524601
Author: lydia-duncan
Link: Deprecate old Sort functions and replace with new argument lists by lydia-duncan · Pull Request #25625 · chapel-lang/chapel · GitHub
Log Message:
Deprecate old Sort functions and replace with new argument lists (#25625)

[reviewed by @jabraham17]

Resolves #25544

Implements the decisions reached by the Sort discussion team. Updates
the argument lists for:

  • sort by renaming the array argument and removing the
    inPlaceAlgorithm argument (which was confusing), and removing the
    queries. Also uses new DefaultComparator() instead of the
    module-scoped variable.
  • isSorted by renaming the array argument, removing the queries and
    using new DefaultComparator() instead of the module-scoped variable.
  • and the sorted iterator by removing the queries and using new DefaultComparator() instead of the module-scoped variable.

The sorted iterator did not need a deprecation for this change.

Adds tests locking in the deprecation messages for sort and
isSorted.

Passed a full paratest with futures

Compare: Comparing 10cce9a22ba41eb4c5b46df9b4beead373c7c579...c7a06df955060cf395d3c331dd1cb1f1fc7b2428 · chapel-lang/chapel · GitHub

Diff:
M modules/standard/Sort.chpl
A test/deprecated/Sort/depSortInPlace.chpl
A test/deprecated/Sort/depSortInPlace.good
A test/deprecated/Sort/isSortedDep.chpl
A test/deprecated/Sort/isSortedDep.good
https://github.com/chapel-lang/chapel/pull/25625.diff