Branch: refs/heads/main
Revision: 5630f4c
Author: daviditen
Link: Deprecate constant pipe styles for Subprocess and replace with an enum by daviditen · Pull Request #19366 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19366 from daviditen/subprocess-rename-pipe-options
Deprecate constant pipe styles for Subprocess and replace with an enum
[reviewed by @lydia-duncan]
Deprecate the Subprocess constants FORWARD, CLOSE, PIPE, STDOUT, BUFFERED_PIPE
and make them an enum with values forward, close, pipe, stdout, bufferAll.
Update tests and Mason to use the new names. Add a deprecation test.
Closes https://github.com/Cray/chapel-private/issues/2769
Closes https://github.com/Cray/chapel-private/issues/2012
Closes https://github.com/Cray/chapel-private/issues/3106
Signed-off-by: David Iten daviditen@users.noreply.github.com
Modified Files:
A test/deprecated/subprocess-pipe-types.chpl
A test/deprecated/subprocess-pipe-types.good
M modules/standard/Subprocess.chpl
M test/arrays/skyline/spawnPromoteBug.chpl
M test/chplenv/autocomplete/autocomplete.chpl
M test/classes/initializers/initequals/useOnly.chpl
M test/library/packages/Curl/RunServer.chpl
M test/library/packages/HDF5/HDF5Preprocessors.chpl
M test/library/packages/ProtobufProtocolSupport/endToEndRunnerUtils.chpl
M test/library/standard/Path/victor-ludorum/testcases_isAbsPath.chpl
M test/library/standard/Spawn/cat-test.chpl
M test/library/standard/Spawn/cat-test.good
M test/library/standard/Spawn/redirect-stderr-stdout.chpl
M test/library/standard/Spawn/spawn-error2.chpl
M test/library/standard/Spawn/spawn-popen-input-error-long.chpl
M test/library/standard/Spawn/spawn-popen-input-output-error-long.chpl
M test/library/standard/Spawn/spawn-popen-input-output-error.chpl
M test/library/standard/Spawn/spawn-popen-input-output-long.chpl
M test/library/standard/Spawn/spawn-popen-input-output.chpl
M test/library/standard/Spawn/spawn-popen-input.chpl
M test/library/standard/Spawn/spawn-popen-wait.chpl
M test/library/standard/Spawn/spawn-popen.chpl
M test/library/standard/Spawn/spawn-popen2.chpl
M test/library/standard/Spawn/two-waits.chpl
M test/library/standard/Spawn/ugni/spawn-system.chpl
M test/mason/MasonTestHelpers.chpl
M test/mason/mason-help-tests/masonHelpTests.chpl
M test/studies/comd/elegant/arrayOfStructs/CoMD.chpl
M test/studies/dedup/dedup-distributed-ints.chpl
M test/studies/dedup/dedup-distributed-strings.chpl
M test/studies/dedup/dedup-local.chpl
M test/studies/dedup/dedup-spawn-sort.chpl
M test/studies/labelprop/labelprop-tweets.chpl
M tools/mason/MasonPublish.chpl
M tools/mason/MasonSystem.chpl
M tools/mason/MasonTest.chpl
M tools/mason/MasonUtils.chpl
Compare: https://github.com/chapel-lang/chapel/compare/934adfbf8c1f...5630f4c60d92