[Chapel Merge] Deprecate bool(w)

Branch: refs/heads/main
Revision: b17064a2f10a03eace56550e8d1dd3c53dc19626
Author: Brad Chamberlain
Link: Deprecate bool(w) by bradcray · Pull Request #21527 · chapel-lang/chapel · GitHub
Log Message:

Deprecate 'bool(w)' in favor of just 'bool' (and, eventually, alignments)
It was proposed in #21002 and [design] deprecate support for `bool(w)`? (but not `bool`) to deprecate bool(w) in favor of a (future) alignment-oriented pragma for cases when users wanted to make sure their bool occupied a certain number of bits of memory. This PR does so by issuing a deprecation warning when bool(w) or bool(?w) is used. Most of the changes in this PR involved updating tests to avoid using bool(w) and removing a few futures that no longer apply. Some tests that were very specific to bool(w) were moved to test/deprecated/bool/ in order to make sure the feature continues working as it has until it's removed. Others that are specific to bool(w), I simply removed. The NetworkAtomics.chpl module seemed to use bool(32), so I changed that to uint(32) which seems as though it should be equivalent for its purposes. Resolves #21002 (directly) Resolves #13142 (by removing the need for it) Resolves #19976 (by removing the need for it)
Compare: Comparing cf2ee15c88d071bdf5d32b27c3054f32991dab95...b17064a2f10a03eace56550e8d1dd3c53dc19626 · chapel-lang/chapel · GitHub
Diff: https://github.com/chapel-lang/chapel/pull/21527.diff
Modified Files:
compiler/AST/build.cpp
compiler/include/build.h
compiler/passes/convert-uast.cpp
compiler/resolution/initializerResolution.cpp
compiler/resolution/typeSpecifier.cpp
frontend/test/resolution/testForwarding.cpp
modules/internal/NetworkAtomics.chpl
test/arrays/johnk/refTypes.chpl
test/constrained-generics/basic/set2/wrappers-for-impl-functions.chpl
test/functions/bradc/resolution/smallIntBoolTests/booldispatch.chpl
test/functions/bradc/resolution/smallIntBoolTests/booldispatch.good
test/functions/bradc/resolution/smallIntBoolTests/testresolve.chpl
test/functions/bradc/resolution/smallIntBoolTests/testresolve.good
test/functions/intents/inout/in-conversion-inout-bool.chpl
test/parallel/begin/deitz/test_control_flow.good
test/parallel/taskPar/taskIntents/01-error-global.chpl
test/parallel/taskPar/taskIntents/01-error-global.good
test/parallel/taskPar/taskIntents/02-error-local.chpl
test/parallel/taskPar/taskIntents/02-error-local.good
test/parallel/taskPar/taskIntents/03-error-in-fun.chpl
test/parallel/taskPar/taskIntents/03-error-in-fun.good
test/parallel/taskPar/taskIntents/11-capture-in-begin.chpl
test/parallel/taskPar/taskIntents/11-capture-in-begin.good
test/parallel/taskPar/taskIntents/12-no-capture-in-begin.chpl
test/parallel/taskPar/taskIntents/12-no-capture-in-begin.good
test/parallel/taskPar/taskIntents/21-capture-in-cobegin.chpl
test/parallel/taskPar/taskIntents/21-capture-in-cobegin.good
test/parallel/taskPar/taskIntents/22-no-capture-in-cobegin.chpl
test/parallel/taskPar/taskIntents/22-no-capture-in-cobegin.good
test/parallel/taskPar/taskIntents/31-capture-in-coforall.chpl
test/parallel/taskPar/taskIntents/31-capture-in-coforall.good
test/parallel/taskPar/taskIntents/32-no-capture-in-coforall.chpl
test/parallel/taskPar/taskIntents/32-no-capture-in-coforall.good
test/parallel/taskPar/taskIntents/src/var-types.h
test/param/errors/checkParamTypes.compopts
test/param/ferguson/param-complex.chpl
test/param/ferguson/param-complex.good
test/param/ferguson/print-type-containing-param-explicit-sizes.chpl
test/param/ferguson/print-type-containing-param-explicit-sizes.good
test/studies/arkouda/sub_test
test/types/scalar/bharshbarg/illegalSizes-1.chpl
test/types/scalar/bharshbarg/illegalSizes-1.good
test/types/scalar/bharshbarg/illegalSizes-2.bad
test/types/scalar/bharshbarg/illegalSizes-2.chpl
test/types/scalar/bharshbarg/illegalSizes-2.good
test/types/scalar/bradc/bools-param.chpl
test/types/scalar/bradc/bools-param.good
test/types/scalar/bradc/bools2-param.chpl
test/types/scalar/bradc/bools2-param.good
test/types/scalar/bradc/bools2.chpl
test/types/scalar/bradc/bools2.good
test/types/scalar/hilde/wantTypeProperties.chpl
test/types/string/kushal/cast_to_bool_ignore_whitespace.chpl
test/types/string/kushal/cast_to_bool_ignore_whitespace.good
test/types/tuple/bradc/unaryTupleOps.chpl
test/types/tuple/bradc/unaryTupleOps.good
test/users/ferguson/cast_to_bool.chpl
test/users/ferguson/cast_to_bool.good
test/users/vass/isX/isX.byBlankArgs-compWarns.chpl
test/users/vass/isX/isX.byBlankArgs-compWarns.good
test/users/vass/isX/isX.module-writeln.chpl
test/users/vass/isX/isX.module-writeln.good
test/users/vass/isX/src/isX.byBlankArgs-compWarns.decls-chpl
test/users/vass/isX/src/isX.byBlankArgs-compWarns.py
test/users/vass/isX/src/isX.module-writeln.decls-chpl
test/users/vass/isX/src/isX.module-writeln.py
util/cron/publish-docker-images.bash

Added Files:
test/classes/forwarding/forwarding-lambda-inner-record.chpl
test/classes/forwarding/forwarding-lambda-inner-record.good
test/classes/initializers/errors/errHandling/calls/tryBangExpressionDefaultRecord.chpl
test/classes/initializers/errors/errHandling/calls/tryBangExpressionDefaultRecord.good
test/classes/initializers/errors/errHandling/calls/tryBangExpressionRecord.chpl
test/classes/initializers/errors/errHandling/calls/tryBangExpressionRecord.good
test/deprecated/bool/overloadbools.good
test/deprecated/bool/overloadbools2.good
test/deprecated/bool/overloadbools3.good
test/deprecated/bool/overloadbools4.good
test/deprecated/bool/resolveQueryType.good
test/deprecated/bool/resolveQueryType2.good
test/deprecated/bool/resolveQueryTypeW.bad
test/deprecated/boolSizes.chpl
test/deprecated/boolSizes.compopts
test/deprecated/boolSizes.good
test/library/standard/FileSystem/lydia/sameFile/closeCopy.compopts
test/statements/loops/labeledLoopWithinNestedCoforall.chpl
test/statements/loops/labeledLoopWithinNestedCoforall.good

Removed Files:
test/portability/boolLiteralSizes.chpl
test/portability/boolLiteralSizes.good
test/portability/boolSizes.chpl
test/portability/boolSizes.good
test/types/bool/bradc/numBitsBytes.chpl
test/types/bool/bradc/numBitsBytes.good
test/types/bool/bradc/preserveWidths.chpl
test/types/bool/bradc/preserveWidths.future
test/types/bool/bradc/preserveWidths.good
test/types/bool/kushal/reportLiteralSize.chpl
test/types/bool/kushal/reportLiteralSize.good
test/types/bool/resolution/resolveQueryType.good
test/types/bool/resolution/resolveQueryType2.good
test/types/bool/resolution/resolveQueryTypeW.bad
test/types/scalar/bradc/overloadbools.good
test/types/scalar/bradc/overloadbools2.good
test/types/scalar/bradc/overloadbools3.good
test/types/scalar/bradc/overloadbools4.good