Branch: refs/heads/main
Revision: 7a8ed885f495432c4b5a8e5189d1c1a18c679e9f
Author: jabraham17
Link: Change promoted array indexing from deprecated to unstable by jabraham17 · Pull Request #23974 · chapel-lang/chapel · GitHub
Log Message:
Change promoted array indexing from deprecated to unstable (#23974)
This changes the deprecation for expressions like A[B] = 1; from a
deprecation into unstable warning.
The deprecation was added in
Deprecate modifying an array in a promoted expression by jabraham17 · Pull Request #23208 · chapel-lang/chapel · GitHub, but after discussion
in Discussion on forall intents · Issue #23819 · chapel-lang/chapel · GitHub we decided to walk
back our decision and allow this again, with a warning about race
conditions.
The goal for this PR is the relax this warning for users for the
upcoming release and then to convert that unstable warning into a race
condition warning.
Testing
- paratest comm=none
- paratest comm=gasnet
Note: this PR has not walked back the spec change in
[Reviewed by @bradcray]
Diff:
M compiler/main/checks.cpp
A test/arrays/promotion/promotedArrayIndexing/COMPOPTS
R100 test/deprecated/promotionOverArrayOfIndices/README test/arrays/promotion/promotedArrayIndexing/README
R100 test/deprecated/promotionOverArrayOfIndices/TestArray.chpl test/arrays/promotion/promotedArrayIndexing/TestArray.chpl
R100 test/deprecated/promotionOverArrayOfIndices/TestArray.notest test/arrays/promotion/promotedArrayIndexing/TestArray.notest
R100 test/deprecated/promotionOverArrayOfIndices/assignment.chpl test/arrays/promotion/promotedArrayIndexing/assignment.chpl
A test/arrays/promotion/promotedArrayIndexing/assignment.good
A test/arrays/promotion/promotedArrayIndexing/const/COMPOPTS
R100 test/deprecated/promotionOverArrayOfIndices/const/TestArray.chpl test/arrays/promotion/promotedArrayIndexing/const/TestArray.chpl
R100 test/deprecated/promotionOverArrayOfIndices/const/TestArray.notest test/arrays/promotion/promotedArrayIndexing/const/TestArray.notest
A test/arrays/promotion/promotedArrayIndexing/const/assignment.chpl
A test/arrays/promotion/promotedArrayIndexing/const/assignment.good
R100 test/deprecated/promotionOverArrayOfIndices/modify-with-free-function.chpl test/arrays/promotion/promotedArrayIndexing/const/modify-with-free-function.chpl
A test/arrays/promotion/promotedArrayIndexing/const/modify-with-free-function.good
R100 test/deprecated/promotionOverArrayOfIndices/modify-with-method.chpl test/arrays/promotion/promotedArrayIndexing/const/modify-with-method.chpl
A test/arrays/promotion/promotedArrayIndexing/const/modify-with-method.good
R100 test/deprecated/promotionOverArrayOfIndices/modify-with-op.chpl test/arrays/promotion/promotedArrayIndexing/const/modify-with-op.chpl
A test/arrays/promotion/promotedArrayIndexing/const/modify-with-op.good
R100 test/deprecated/promotionOverArrayOfIndices/use-with-free-function.chpl test/arrays/promotion/promotedArrayIndexing/const/use-with-free-function.chpl
R100 test/deprecated/promotionOverArrayOfIndices/use-with-free-function.good test/arrays/promotion/promotedArrayIndexing/const/use-with-free-function.good
R100 test/deprecated/promotionOverArrayOfIndices/use-with-method.chpl test/arrays/promotion/promotedArrayIndexing/const/use-with-method.chpl
R100 test/deprecated/promotionOverArrayOfIndices/use-with-method.good test/arrays/promotion/promotedArrayIndexing/const/use-with-method.good
R100 test/deprecated/promotionOverArrayOfIndices/use-with-op.chpl test/arrays/promotion/promotedArrayIndexing/const/use-with-op.chpl
R100 test/deprecated/promotionOverArrayOfIndices/use-with-op.good test/arrays/promotion/promotedArrayIndexing/const/use-with-op.good
A test/arrays/promotion/promotedArrayIndexing/modify-with-free-function.chpl
A test/arrays/promotion/promotedArrayIndexing/modify-with-free-function.good
A test/arrays/promotion/promotedArrayIndexing/modify-with-method.chpl
A test/arrays/promotion/promotedArrayIndexing/modify-with-method.good
A test/arrays/promotion/promotedArrayIndexing/modify-with-op.chpl
A test/arrays/promotion/promotedArrayIndexing/modify-with-op.good
A test/arrays/promotion/promotedArrayIndexing/use-with-free-function.chpl
A test/arrays/promotion/promotedArrayIndexing/use-with-free-function.good
A test/arrays/promotion/promotedArrayIndexing/use-with-method.chpl
A test/arrays/promotion/promotedArrayIndexing/use-with-method.good
A test/arrays/promotion/promotedArrayIndexing/use-with-op.chpl
A test/arrays/promotion/promotedArrayIndexing/use-with-op.good
D test/deprecated/promotionOverArrayOfIndices/assignment.good
D test/deprecated/promotionOverArrayOfIndices/const/assignment.chpl
D test/deprecated/promotionOverArrayOfIndices/const/assignment.good
D test/deprecated/promotionOverArrayOfIndices/const/modify-with-free-function.chpl
D test/deprecated/promotionOverArrayOfIndices/const/modify-with-free-function.good
D test/deprecated/promotionOverArrayOfIndices/const/modify-with-method.chpl
D test/deprecated/promotionOverArrayOfIndices/const/modify-with-method.good
D test/deprecated/promotionOverArrayOfIndices/const/modify-with-op.chpl
D test/deprecated/promotionOverArrayOfIndices/const/modify-with-op.good
D test/deprecated/promotionOverArrayOfIndices/const/use-with-free-function.chpl
D test/deprecated/promotionOverArrayOfIndices/const/use-with-free-function.good
D test/deprecated/promotionOverArrayOfIndices/const/use-with-method.chpl
D test/deprecated/promotionOverArrayOfIndices/const/use-with-method.good
D test/deprecated/promotionOverArrayOfIndices/const/use-with-op.chpl
D test/deprecated/promotionOverArrayOfIndices/const/use-with-op.good
D test/deprecated/promotionOverArrayOfIndices/modify-with-free-function.good
D test/deprecated/promotionOverArrayOfIndices/modify-with-method.good
D test/deprecated/promotionOverArrayOfIndices/modify-with-op.good
https://github.com/chapel-lang/chapel/pull/23974.diff