[Chapel Merge] Another bundle of mason fixes

Notifications Commits
1

Branch: refs/heads/main
Revision: a4ad516d034cacc1f72d5e983748d3348f049dd6
Author: jabraham17
Link: Another bundle of mason fixes by jabraham17 · Pull Request #28462 · chapel-lang/chapel · GitHub
Log Message:
Another bundle of mason fixes (#28462)

Fixes a bunch of issues with Mason revolving around system dependencies
and init/new

Resolves GitHub · Where software is built
Resolves [Bug]: `mason system search` does not work · Issue #28386 · chapel-lang/chapel · GitHub

In this PR

  • refactor a bunch of init/new tests
  • fix mason system search
  • fix mason system dependencies
  • mason system deps can be added by name only
  • fix printing of some logs
  • removed MASON_QUIET
  • paratest

Future work: this PR fixes some things, but further reveals how badly a
major refactor is needed. The logic for computing dependencies/compopts
is so spread out and hard to reason about and needs to be in a central
location. For example, with the current implementation I am pretty sure
external deps are broken and will not work and that transitive
dependencies (like foo -> bar -> myProgram) needs work. But to even
contemplate fixing these glaring issues, major refactoring is needed.

[Reviewed by @benharsh]

Compare: Comparing d5b6f061f2b43e73ccad5d0e4d792bf625f1123d...fcfe1fadb05cb070c9d27cc0e93763ffbc8902f1 · chapel-lang/chapel · GitHub

Diff:
M test/mason/EXECENV
M test/mason/MasonBashSubTest
M test/mason/mason-help-tests/masonHelpTests.good
A test/mason/mason-new-init/.gitignore
A test/mason/mason-new-init/CLEANFILES
R100 test/mason/masonInit/EXECENV test/mason/mason-new-init/EXECENV
A test/mason/mason-new-init/init.masontest
A test/mason/mason-new-init/initErrors.good
A test/mason/mason-new-init/initErrors.masontest
A test/mason/mason-new-init/initErrors.prediff
A test/mason/mason-new-init/masonNewBadName.good
A test/mason/mason-new-init/masonNewBadName.masontest
A test/mason/mason-new-init/new.masontest
A test/mason/mason-new-init/newErrors.good
A test/mason/mason-new-init/newErrors.masontest
A test/mason/mason-new-init/nogit.good
A test/mason/mason-new-init/nogit.masontest
A test/mason/mason-new-init/nogit.prediff
A test/mason/mason-new-init/sub_test
A test/mason/mason-system/.gitignore
A test/mason/mason-system/CLEANFILES
R100 test/mason/new/EXECENV test/mason/mason-system/EXECENV
A test/mason/mason-system/PREDIFF
A test/mason/mason-system/buildWithSystemDeps.good
A test/mason/mason-system/buildWithSystemDeps.masontest
A test/mason/mason-system/buildWithSystemDeps.prediff
R100 test/mason/new/project.notest test/mason/mason-system/local-reg.notest
A test/mason/mason-system/mason_home.notest
A test/mason/mason-system/myDep.notest
A test/mason/mason-system/myDep/Mason.toml
A test/mason/mason-system/myDep/src/myDep.chpl
A test/mason/mason-system/myMasonPackage.notest
A test/mason/mason-system/myMasonPackage/Mason.toml
A test/mason/mason-system/myMasonPackage/example/example.chpl
A test/mason/mason-system/myMasonPackage/src/myMasonPackage.chpl
A test/mason/mason-system/myMasonPackage/test/Test.chpl
A test/mason/mason-system/myPackages.notest
A test/mason/mason-system/myPackages/anotherPackage.pc
A test/mason/mason-system/myPackages/dummy.pc
A test/mason/mason-system/myPackages/forGoodMeasure.pc
A test/mason/mason-system/myPackages/myOtherPackage.pc
A test/mason/mason-system/myPackages/myWeirdPackage.pc
A test/mason/mason-system/pc.good
A test/mason/mason-system/pc.masontest
A test/mason/mason-system/search.good
A test/mason/mason-system/search.masontest
A test/mason/mason-system/sub_test
A test/mason/mason-system/systemadd.good
A test/mason/mason-system/systemadd.masontest
A test/mason/mason-system/systemadd.prediff
A test/mason/mason-system/tempMasonLib.notest
D test/mason/masonInit/CLEANFILES
D test/mason/masonInit/SKIPIF
D test/mason/masonInit/masonInitModule.chpl
D test/mason/masonInit/masonInitModule.compopts
D test/mason/masonInit/masonInitModule.good
D test/mason/masonInit/masonInitPathTest.chpl
D test/mason/masonInit/masonInitPathTest.compopts
D test/mason/masonInit/masonInitPathTest.good
D test/mason/masonInit/masonInitTest.chpl
D test/mason/masonInit/masonInitTest.compopts
D test/mason/masonInit/masonInitTest.good
D test/mason/masonInit/masonInitTest2.chpl
D test/mason/masonInit/masonInitTest2.compopts
D test/mason/masonInit/masonInitTest2.good
D test/mason/masonInit/masonInitTest3.chpl
D test/mason/masonInit/masonInitTest3.compopts
D test/mason/masonInit/masonInitTest3.good
D test/mason/masonInit/masonInitTest3.prediff
D test/mason/masonNewBadName.0bad.good
D test/mason/masonNewBadName.bad-name.good
D test/mason/masonNewBadName.bad.name.good
D test/mason/masonNewBadName.badstuff.good
D test/mason/masonNewBadName.chpl
D test/mason/masonNewBadName.compopts
D test/mason/masonNewBadName.empty.good
D test/mason/masonNewBadName.execopts
D test/mason/masonNewBadName.existingdir.good
D test/mason/masonNewBadName.skipif
D test/mason/masonNewModule.chpl
D test/mason/masonNewModule.compopts
D test/mason/masonNewModule.good
D test/mason/masonNewTest.chpl
D test/mason/masonNewTest.compopts
D test/mason/masonNewTest.good
D test/mason/new/CLEANFILES
D test/mason/new/COMPOPTS
D test/mason/new/PREDIFF
D test/mason/new/SKIPIF
M test/mason/search/badFileName/mason-search.chpl
M test/mason/search/mason-search.chpl
M tools/mason/Mason.chpl
M tools/mason/MasonBuild.chpl
M tools/mason/MasonExample.chpl
M tools/mason/MasonHelp.chpl
M tools/mason/MasonInit.chpl
M tools/mason/MasonLogger.chpl
M tools/mason/MasonModify.chpl
M tools/mason/MasonNew.chpl
M tools/mason/MasonSystem.chpl
M tools/mason/MasonTest.chpl
M tools/mason/MasonUpdate.chpl
M tools/mason/MasonUtils.chpl
https://github.com/chapel-lang/chapel/pull/28462.diff