[Chapel Merge] Add a Github Actions workflow to run ShellCheck

Notifications Commits
1

Branch: refs/heads/main
Revision: bfbe44137137d1a907bfb212deb9c0f8c8f7ce9c
Author: arifthpe
Link: Add a Github Actions workflow to run ShellCheck by arifthpe · Pull Request #28719 · chapel-lang/chapel · GitHub
Log Message:
Add a Github Actions workflow to run ShellCheck (#28719)

Add a workflow which uses this Github
Action to run
ShellCheck on our shell scripts, and fix
all the errors it found.

Notes:

  • Excludes test and third-party dirs.
  • Limits to complaining about errors of the highest severity, error.
  • Includes adding ShellCheck shell
    directive
    comments to some .sh files that are only sourced and not run, so they
    have no shebang and ShellCheck can't otherwise guess which shell to use.
  • Adds comment directive to ignore an error resulting from use of
    zsh-specific feature in setchplenv.bash, a script intended to be
    sourced from either bash or zsh.

[reviewed by @jabraham17, thanks!]

Testing:

  • check passes

Compare: Comparing 45601212316f8492e0d0e612e756771d5f9039d0...30ac6610cc03ab751900e2115c72377a5488d996 · chapel-lang/chapel · GitHub

Diff:
A .github/workflows/shellcheck.yml
M configure
M tools/mason/pullMasonDeps
M util/buildRelease/install.sh
M util/buildRelease/test_install.bash
M util/buildRelease/test_rpm_module.bash
M util/build_configs/functions.bash
M util/build_configs/module-functions.bash
M util/cron/common-arkouda.bash
M util/devel/chpl-run
M util/devel/gen-chpl-bash-completion
M util/devel/test/checkIgnore.sh
M util/devel/test/getFailedTestNames
M util/misc/gen-LAPACK/run.sh
M util/packaging/common/build_helpers.sh
M util/quickstart/setchplenv.bash
M util/quickstart/setchplenv.sh
M util/setchplenv.bash
M util/setchplenv.sh
M util/test/timers/defaultTimer
https://github.com/chapel-lang/chapel/pull/28719.diff