Branch: refs/heads/main
Revision: 694c222d0375898b7fdee1d55e21d757b8483f30
Author: Lydia Duncan
Link: [Merge pull request] # 20986 from lydia-duncan:syncDeprecationMsgStuff Adjust deprecation of sync `init=` and `initCopy` by lydia-duncan · Pull Request #20986 · chapel-lang/chapel · GitHub
Log Message:
[Merge pull request] # 20986 from lydia-duncan:syncDeprecationMsgStuff
Make these more official deprecations
These warnings were added before the deprecated keyword was implemented. While the tests of this deprecation that were already checked into the repo gave a useful pointer to the code that was triggering the call, I encountered a scenario where this was not the case because this deprecation was using the old compilerWarning strategy rather than the new keyword. This warning was in a place where I wasn't certain how to fix the code to avoid it, otherwise I would have removed the deprecation warning since it has been there for a while. Adds two test that were positively impacted by this change. They are futures because they demonstrate #20984 Adjusted the expected output of one test - I believe this is okay, the deprecation messages looked to be redundant with the error messages that are causing the program to fail to compile. I think they don't turn up now because we do a "gather all errors and halt" stage before entering the part of resolution that triggers the deprecated keyword handling, but that stage happens after compilerWarnings are triggered. Passed a full paratest with futures
Compare: Comparing 02b95d5d8d92b8ea27ffe663fefa40ee1156f249...694c222d0375898b7fdee1d55e21d757b8483f30 · chapel-lang/chapel · GitHub
Diff: https://github.com/chapel-lang/chapel/pull/20986.diff
FilesChanged: Adjust deprecation of sync `init=` and `initCopy` by lydia-duncan · Pull Request #20986 · chapel-lang/chapel · GitHub
Modified Files:
compiler/AST/build.cpp,modules/internal/ChapelBase.chpl,modules/internal/ChapelSyncvar.chpl,test/arrays/slices/commCounts/sliceBlockWithRanges.na-none.good,test/arrays/slices/commCounts/sliceLocDist.na-none.good,test/distributions/bharshbarg/promotedComms.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc_all.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc_all.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc_all.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assign.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assign.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assign.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignAlias.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignAlias.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignAlias.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignReindex.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignReindex.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignReindex.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduce.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduce.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduce.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceAlias.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceAlias.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceAlias.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignReindex.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignReindex.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignReindex.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignSlice.cyclic.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/reduceSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/reduceSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/reduceSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/reduceSlice2.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/sliceOps.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/sliceOps.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/sliceOps.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/sliceOps.cyclic.na-none.good,test/library/standard/CommDiagnostics/commDiagsTable.good,test/library/standard/CommDiagnostics/commDiagsTable.na-none.good,test/library/standard/Types/copyable-sync-string.bad,test/library/standard/Types/copyable-sync-string.chpl,test/library/standard/Types/copyable-sync-string.future,test/library/standard/Types/copyable-sync-string.good,test/modules/sungeun/init/printInitCommCounts.good,test/modules/sungeun/init/printModuleInitOrder.na-none.good,test/multilocale/deitz/needMultiLocales/dist/test_private_space.na-none.good,test/multilocale/deitz/needMultiLocales/raCommCheck.na-none.good,test/multilocale/deitz/needMultiLocales/raCommCheckLCG.na-none.good,test/multilocale/deitz/needMultiLocales/streamCommCheck.na-none.good,test/optimizations/remoteValueForwarding/serialization/domains.na-none.good,test/optimizations/remoteValueForwarding/zippedSlices/promotion.good,test/optimizations/remoteValueForwarding/zippedSlices/promotion.na-none.good,test/optimizations/remoteValueForwarding/zippedSlices/promotionMany.good,test/optimizations/remoteValueForwarding/zippedSlices/promotionMany.na-none.good,test/parallel/taskPar/sungeun/barrier/commDiags.na-none.good,test/performance/ferguson/array-assign-block.chpl,test/performance/ferguson/cyclic-id-queries.chpl,test/performance/sungeun/multilocale/atomics.na-none.good,test/performance/sungeun/multilocale/syncsingle.na-none.good,test/scan/scanDiags.good,test/scan/scanDiags.na-none.good,test/studies/hpcc/CommDiags/ra_commDiags.na-none.good,test/studies/hpcc/CommDiags/stream-ep_commDiags.na-none.good,test/studies/hpcc/CommDiags/stream_commDiags.na-none.good,test/types/sync/lydia/arrayOfArrayOfSyncsInField.bad,test/types/sync/lydia/arrayOfArrayOfSyncsInField.chpl,test/types/sync/lydia/arrayOfArrayOfSyncsInField.future,test/types/sync/lydia/arrayOfArrayOfSyncsInField.good,test/types/sync/vass/error-storing-in-tuple.good,util/cron/test-cray-xc-gpu-arkouda.bash
Removed Files:
test/arrays/slices/commCounts/sliceBlockWithRanges.na-none.good,test/arrays/slices/commCounts/sliceLocDist.na-none.good,test/distributions/bharshbarg/promotedComms.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc_all.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc_all.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/alloc_all.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assign.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assign.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assign.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignAlias.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignAlias.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignAlias.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignReindex.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignReindex.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignReindex.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/assignSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduce.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduce.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduce.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceAlias.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceAlias.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceAlias.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/reduceSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignReindex.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignReindex.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignReindex.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/assignSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/reduceSlice.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/reduceSlice.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/reduceSlice.replicated.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/sliceOps.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/rvfSlices/sliceOps.cyclic.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/sliceOps.block.na-none.good,test/distributions/robust/arithmetic/performance/multilocale/sliceOps.cyclic.na-none.good,test/library/standard/CommDiagnostics/commDiagsTable.na-none.good,test/modules/sungeun/init/printModuleInitOrder.na-none.good,test/multilocale/deitz/needMultiLocales/dist/test_private_space.na-none.good,test/multilocale/deitz/needMultiLocales/raCommCheck.na-none.good,test/multilocale/deitz/needMultiLocales/raCommCheckLCG.na-none.good,test/multilocale/deitz/needMultiLocales/streamCommCheck.na-none.good,test/optimizations/remoteValueForwarding/serialization/domains.na-none.good,test/optimizations/remoteValueForwarding/zippedSlices/promotion.na-none.good,test/optimizations/remoteValueForwarding/zippedSlices/promotionMany.na-none.good,test/scan/scanDiags.na-none.good,test/studies/hpcc/CommDiags/ra_commDiags.na-none.good,test/studies/hpcc/CommDiags/stream-ep_commDiags.na-none.good,test/studies/hpcc/CommDiags/stream_commDiags.na-none.good