New Issue: [Library Stabilization] What should we do with the 'fits_*' methods in BigInteger?

Notifications Issues
1

17702, "lydia-duncan", "[Library Stabilization] What should we do with the 'fits_*' methods in BigInteger?", "2021-05-12T21:21:41Z"

The following methods on the bigint type seem out of place:

  • bigint.fits_ulong_p()
  • bigint.fits_slong_p()
  • bigint.fits_uint_p()
  • bigint.fits_sint_p()
  • bigint.fits_ushort_p()
  • bigint.fits_sshort_p()

I can think of a few options:

  • We could move them into the GMP module along with the mpzStruct and potentially "limbs" methods (see #17694 and #17695)
  • We could define Chapel type equivalents (e.g. fitsInt, fitsUint, fitsInt64 or something)
  • We could just remove them

If we keep them, I think they should return booleans like the functions in #17701