18086, "stonea", "Array module review followup: Should isRectangularArr, isIreggularArr, etc. be moved to be methods on array type? ", "2021-07-21T15:15:30Z"
This is a followup item for the Array module review.
One item we wanted further discussion on is:
whether or not we should move isRectangularArr(), isIrregularArr() etc. to be functions on the array type. Currently these are free functions.
One justification for them being free (rather than on the type itself) is in a generic function you may want to see if you want to query whether some unknown datatypes is a rectangular array and you don't want a compile-time error if the underlying type isn't an array. Of course a simple workaround would be to just do this: if(isArray(A) && A.isRectangular)