Branch: refs/heads/main
Revision: ef4e4e4
Author: mppf
Link: Update good file and add bad file for const-ref-tuple-decl test by cassella · Pull Request #19393 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19393 from cassella/const-ref-tuple-decl-bad
Update good file and add bad file for const-ref-tuple-decl test
[PR by @cassella - thanks! Reviewed/merged by @mppf]
The good file had gone stale wrt the arrays in main() no longer being
separately default inited and then assigned to. They're now
initialized directly. Update the .good file by removing the default
init of the array elements, the assignments, and the deinit of the
temporaries the array had been initialized from.
Add a .bad file. This required adding a serial block around the body
of commonPrefixLength(). The undesired array copying was parallel and
nondeterministic. Add a serial block around it all so that the output
is deterministic. This does not appear to affect the behavior of the
code under test or of the correctly-functioning alternative.
Add a note to remove the serial block once the future is retired.
Modified Files:
A test/types/tuple/ferguson/const-ref-tuple-decl.bad
M test/types/tuple/ferguson/const-ref-tuple-decl.chpl
M test/types/tuple/ferguson/const-ref-tuple-decl.future
M test/types/tuple/ferguson/const-ref-tuple-decl.good
Compare: https://github.com/chapel-lang/chapel/compare/f9859e4a831d...ef4e4e4c679d