[Chapel Merge] This PR Deprecates the NUMA locale-model, locale.g

Notifications Commits
1

Branch: refs/heads/main
Revision: ec6ab8c
Author: jeremiah-corrado
Link: Deprecate NUMA locale-model, getChild() and getChildCount() by jeremiah-corrado · Pull Request #20428 · chapel-lang/chapel · GitHub
Log Message:

Merge pull request #20428 from jeremiah-corrado/deprecateNUMA

This PR Deprecates the NUMA locale-model, locale.getChild() and locale.getChildCount()

NUMA Deprecation:

  • Compiling with CHPL_LOCALE_MODEL=numa now issues a deprecation warning which indicates that the 'flat' model should be used instead
  • A deprecation tests was added
  • NUMA specific tests were removed
  • Relevant documentation was updated to indicate that this locale model is deprecated (technical details about the model remain in the docs for now)
  • printchplenv.py was modified to print: "CHPL_LOCALE_MODEL: numa * (deprecated)" when CHPL_LOCALE_MODEL=numa

getChild, getChildCount Deprecation:

  • Both methods were already no doc-ed; however, they were prevalent in example code related to GPU's and NUMA, so they were marked as deprecated
  • Deprecation tests were added
  • Tests relying on these methods were either removed or modified
  • locale._getChild() and locale._getChildCount() were added for internal use (to avoid triggering the deprecation warning during locale initialization, etc.)

In a separate PR, Bhavani updated jenkins configs to stop testing with CHPL_LOCALE_MODEL=numa.

[reviewed by @jhh67] - Thanks!

Modified Files:
A test/deprecated/localeGetChild.chpl

A test/deprecated/localeGetChild.good
A test/deprecated/localeGetChild.skipif
A test/deprecated/localeGetChildCount.chpl
A test/deprecated/localeGetChildCount.good
A test/deprecated/localeGetChildCount.skipif
A test/deprecated/numaLocaleModel.chpl
A test/deprecated/numaLocaleModel.good
A test/deprecated/numaLocaleModel.skipif
R test/localeModels/numa.skipif
R test/localeModels/numa/basics/bad_children.chpl
R test/localeModels/numa/basics/bad_children.good
R test/localeModels/numa/basics/checkSubloc.chpl
R test/localeModels/numa/basics/checkSubloc.good
R test/localeModels/numa/basics/coforall_on.chpl
R test/localeModels/numa/basics/coforall_on.good
R test/localeModels/numa/basics/coforall_on.prediff
R test/localeModels/numa/basics/hello7-taskpar-sublocs.chpl
R test/localeModels/numa/basics/hello7-taskpar-sublocs.execopts
R test/localeModels/numa/basics/hello7-taskpar-sublocs.good
R test/localeModels/numa/basics/hello7-taskpar-sublocs.prediff
R test/localeModels/numa/basics/on.chpl
R test/localeModels/numa/basics/on.good
R test/localeModels/numa/dataParallel/forall.chpl
R test/localeModels/numa/dataParallel/forall.compopts
R test/localeModels/numa/dataParallel/forall.good
R test/localeModels/numa/dataParallel/forall.prediff
R test/localeModels/numa/dataParallel/partitionRanges.chpl
R test/localeModels/numa/dataParallel/partitionRanges.good
R test/localeModels/numa/dataParallel/partitionRanges.prediff
R test/localeModels/numa/dataParallel/partitionRanges.skipif
R test/optimizations/localon/bad-id.bad
R test/optimizations/localon/bad-id.chpl
R test/optimizations/localon/bad-id.future
R test/optimizations/localon/bad-id.good
R test/optimizations/localon/bad-id.skipif
R test/runtime/gbt/topo/array-loc.chpl
R test/runtime/gbt/topo/array-loc.cleanfiles
R test/runtime/gbt/topo/array-loc.execopts
R test/runtime/gbt/topo/array-loc.have-locality.good
R test/runtime/gbt/topo/array-loc.no-locality.good
R test/runtime/gbt/topo/array-loc.prediff
R test/runtime/gbt/topo/array-loc.skipif
R test/runtime/gbt/topo/array-loc.suppressif
M doc/rst/developer/bestPractices/TestSystem.rst
M doc/rst/technotes/localeModels.rst
M doc/rst/usingchapel/chplenv.rst
M modules/internal/ChapelLocale.chpl
M modules/internal/ChapelRange.chpl
M modules/internal/DefaultRectangular.chpl
M modules/internal/LocaleModelHelpNUMA.chpl
M modules/internal/LocaleTree.chpl
M modules/internal/localeModels/apu/LocaleModel.chpl
M modules/internal/localeModels/flat/LocaleModel.chpl
M modules/internal/localeModels/gpu/LocaleModel.chpl
M modules/internal/localeModels/numa/LocaleModel.chpl
M modules/packages/BLAS.chpl
M test/arrays/ferguson/default-rectangular-targetlocales.chpl
M test/localeModels/gbt/maxTaskPar.chpl
M test/localeModels/gbt/maxTaskPar.prediff
M test/localeModels/gbt/maxTaskPar.skipif
M test/optimizations/localon/sublocale.chpl
M test/types/locale/promotedCalls.chpl
M util/chplenv/printchplenv.py

Compare: https://github.com/chapel-lang/chapel/compare/09e1008e716c...ec6ab8c626b4