Branch: refs/heads/main
Revision: 07e7a7e
Author: slnguyen
Link: Unavailable
Log Message:
Merge pull request #19365 from slnguyen/rename_regex_fields
This PR changes the regexMatch fields offset and size to byteOffset and numBytes following the discussion in #19076. The old fields (offset and size) are now paren-less procs so that a deprecation warning can be added and the number of fields in the regexMatch record remains the same.
This PR also:
- modifies the IO module and record parser package to use the renamed fields
- modifies regex tests to use the renamed fields
- adds a new deprecation test
Passed paratests with CHPL_RE2=bundled
Reviewed by @lydia-duncan
Modified Files:
A test/deprecated/regexMatchFields.chpl
A test/deprecated/regexMatchFields.good
M modules/packages/RecordParser.chpl
M modules/standard/IO.chpl
M modules/standard/Regex.chpl
M test/deprecated/regexMatchesArgs.good
M test/deprecated/regexpSearch.good
M test/regex/bytes/cast.good
M test/regex/emptyregex.chpl
M test/regex/ferguson/regex-no-leak.good
M test/regex/ferguson/regexp.good
M test/regex/localFastPath.good
M test/regex/maxMatches.good
Compare: https://github.com/chapel-lang/chapel/compare/aff780ac4cda...07e7a7ec1df3