Branch: refs/heads/main
Revision: 6a40237
Author: DanilaFe
Link: Suppress failures from deep recursion under ASAN by DanilaFe · Pull Request #20637 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #20637 from DanilaFe/skip-deep-recursion-asan
Suppress failures from deep recursion under ASAN
ASAN significantly increases the size of stack frames. In some experiments, size seemed to go up from roughly 0x180 to 0x2ef0, which is ~32x larger. Thus, recursive functions that are far from hitting their depth limit under normal circumstances are at risk of stack overflow. In particular, the superbigif and bug-from-issue-9047 tests have large ASTs, and the doAssignIDs function that recursively traverses the ASTs overflows the stack. Since the tests work fine under normal circumstances, it seems like the best course of action is to simply disable the failing cases in ASAN testing. In the future, should recursion depth become a problem in production Chapel code, doAssignIDs can be updated to use something like a queue.
Reviewed by @ronawho - thanks!
Signed-off-by: Danila Fedorin daniel.fedorin@hpe.com
Modified Files:
A test/parsing/superbigif.suppressif
A test/users/ibertolacc/bug-from-issue-9047.suppressif
Compare: https://github.com/chapel-lang/chapel/compare/ed4517010cc8...6a4023756c06