[Chapel Merge] Revert c2chapel record generation idiom change

Branch: refs/heads/main
Revision: 95b0a40
Author: bmcdonald3
Log Message:

Merge pull request #18483 from bmcdonald3/revert-c2chapel

Revert c2chapel record generation idiom change

[reviewed by @ronawho]

The previous PR I filed to change the c2chapel record idiom fixed a very specific case that was seen in a few spots in the Arrow headers. This was fixed by adding "struct typeName" to extern record definitions and I thought that would work in all cases, but due to differences between the C backend and LLVM backends with C interoperability this was not the case, so I am reverting that change because the difficulties of supporting this seem to outweigh the benefits.

Reverted PR: #18355

Modified Files:
M tools/c2chapel/c2chapel.py

M tools/c2chapel/test/arrayDecl.chpl
M tools/c2chapel/test/chapelKeywords.chpl
M tools/c2chapel/test/enum.chpl
M tools/c2chapel/test/fileGlobals.chpl
M tools/c2chapel/test/fnPointers.chpl
M tools/c2chapel/test/gnuTest.chpl
M tools/c2chapel/test/miscTypedef.chpl
M tools/c2chapel/test/nestedStruct.chpl
M tools/c2chapel/test/opaqueStruct.chpl
M tools/c2chapel/test/simpleRecords.chpl

Compare: https://github.com/chapel-lang/chapel/compare/dd4ad77314bb...95b0a40bbb0b