Branch: refs/heads/main
Revision: 7f43142
Author: bradcray
Link: Restore intended PTRANS.valgrind behavior by bradcray · Pull Request #19289 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19289 from bradcray/dont-run-ptrans-twice
Restore intended PTRANS.valgrind behavior
[reviewed by @aconsroe-hpe]
This test's behavior started changing when we started running
initialization for all modules named on the command-line in #18724.
This is because we were calling main once for the --main-module
of PTRANS and once for the explicit call to main() in the PTRANS.valgrind
module. When writing this, the author (could've been me) presumably
imagined that their explicit call to main() was happening and necessary
when in fact neither was true. Since we permit users to call main(), the
test started working differently / as now intended when #18724 was
merged, but not how we expected. Here, I'm removing the explicit
call to main() to restore the expected behavior.
Thanks to @aconsroe-hpe for helping to diagnose this!
Modified Files:
M test/studies/hpcc/PTRANS/PTRANS.valgrind.chpl
Compare: https://github.com/chapel-lang/chapel/compare/9e8e6a24a270...7f43142b27b4