Branch: refs/heads/main
Revision: 4865d4e
Author: vasslitvinov
Link: Rename domain.isSuper/isSubset --> domain.contains by vasslitvinov · Pull Request #19104 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19104 from vasslitvinov/domain-contains
Rename domain.isSuper/isSubset --> domain.contains
This PR implements an action item from the domain module review,
where we decided to switch from using the domain methods
isSuper[Set]/isSubset to using domain.contains(other).
Specifically:
-
Introduce
domain.contains(other), preserving the core algorithms
from isSuper/isSubset -
Add deprecation warnings on isSuper/isSubset and redirect them to contains()
-
Introduce a test for
domain.contains(other):
test/domains/userAPI/contains.chpl
which expands upon and replaces previous tests of isSuper/isSubset:
test/associative/bharshbarg/domains/rectDom.chpl
test/associative/bharshbarg/domains/subset.chpl -
Update our code base for this change.
-
Add tests for the deprecation warnings.
r: @dlongnecke-cray
Modified Files:
A test/deprecated/domain-isSubSuper.chpl
A test/deprecated/domain-isSubSuper.good
A test/domains/compilerErrors/contains-idxtype.chpl
A test/domains/compilerErrors/contains-idxtype.good
A test/domains/compilerErrors/contains-rank.chpl
A test/domains/compilerErrors/contains-rank.good
A test/domains/userAPI/contains.chpl
A test/domains/userAPI/contains.good
R test/associative/bharshbarg/domains/rectDom.chpl
R test/associative/bharshbarg/domains/rectDom.good
R test/associative/bharshbarg/domains/subset.chpl
R test/associative/bharshbarg/domains/subset.good
M modules/internal/ChapelAutoLocalAccess.chpl
M modules/internal/ChapelDistribution.chpl
M modules/internal/ChapelDomain.chpl
Compare: https://github.com/chapel-lang/chapel/compare/c1f1b91ef490...4865d4ed0f85