Branch: refs/heads/main
Revision: 8bf656e
Author: mppf
Link: Remove workarounds for issue #15756 by mppf · Pull Request #20456 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #20456 from mppf/for-15756
Remove workarounds for issue #15756
Resolves #15756. Test change only.
Issue #15756 listed 3 tests that had workarounds for an issue with
split-init combined with sync variables. However the workarounds are no
longer needed now that we have deprecated assignment to sync variables
since the s.writeEF calls do not activate split-init.
A sync variable can be split-initialized today without any deprecation
warning e.g. var s: sync int; ...; s = true;. However:
- if an assignment is desired, it would need to be
writeEFor else be
a deprecation - if the code in the
...uses the sync variable, it should be an error
reported by the compiler (for module-level code or code within a
function)
We still have issue #15769 for the more general question of how one
should write a variable that isn't default initialized.
Reviewed by @ronawho - thanks!
Modified Files:
M test/functions/deitz/nested/test_nested_with_begin.chpl
M test/parallel/begin/waynew/simple2.chpl
M test/parallel/taskPool/figueroa/TooManyThreads.chpl
Compare: https://github.com/chapel-lang/chapel/compare/658369b815b2...8bf656e82e34