Branch: refs/heads/master
Revision: 9431622
Author: lydia-duncan
Log Message:
Merge pull request #16577 from lydia-duncan/removeSecondaryInitWarning
Remove warning for defining initializer outside of the type’s module
[reviewed by @vasslitvinov]
It was originally added because we had trouble determining whether to generate
a default constructor or initializer for the type. Now that constructors are
no longer available, it should not matter as much.
Resolves #16495
Updates 6 tests for the new expected behavior. These tests were locking in the
warning message when a type only has a secondary initializer defined in another
module, which was a problem during the transition between constructors and
initializers. Now that initializers are fully supported and constructors are no
longer supported, the warning is no longer necessary so was removed from the
compiler. As a consequence, these tests no longer need to expect that warning
message. Additionally, the future inDiffModule2.chpl had failed to be updated due
to not having a .bad file and not adjusting for owned being the default for classes -
so update the test to no longer delete an owned instance and remove the .future
because it now passes. Also added a call to the generated default initializer,
because that should always be present.
Full paratest with futures passed
Modified Files:
R test/classes/initializers/secondary/inDiffModule2.future
M compiler/AST/AggregateType.cpp
M test/classes/initializers/secondary/inDiffModule.good
M test/classes/initializers/secondary/inDiffModule2.chpl
M test/classes/initializers/secondary/inDiffModule2.good
M test/classes/initializers/secondary/inDiffModule3.good
M test/classes/initializers/secondary/inDiffModuleBothSecondaryAndPrimary.good
M test/classes/initializers/secondary/inDiffModuleBothSecondaryAndPrimary2.good
M test/functions/generic/poi/check-gc-reuse-opers.good
Compare: https://github.com/chapel-lang/chapel/compare/7d9a4c134264...9431622f23e4