[Chapel Merge] Remove commonFlags.[cpp|h]

Branch: refs/heads/main
Revision: 977e6c8422a846f0c452c1d88837cbcefd05fd2b
Author: bradcray
Link: Remove commonFlags.[cpp|h] by bradcray · Pull Request #21936 · chapel-lang/chapel · GitHub
Log Message:
Remove commonFlags.[cpp|h] (#21936)

[reviewed by @arezaii]

This removes the commonFlags.cpp and .h files, which were originally
introduced to share common flags between chpl and chpldoc when those
shared code and were a single binary. Now that they're not, these files
only add indirection and the opportunity for confusion (like not keeping
flag names alphabetized), so this change removes them, folding their
definitions back to the files they came from.

Resolves #21928.

Compare: Comparing c69f8015084aa5c9c6af401a86a601c7e741749c...2f50bdc5d94e9e3caff90a26e811bb8877b6eddd · chapel-lang/chapel · GitHub

Diff:
M compiler/main/CMakeLists.txt
M compiler/main/Makefile.share
D compiler/main/commonFlags.cpp
D compiler/main/commonFlags.h
M compiler/main/driver.cpp
M compiler/util/files.cpp
https://github.com/chapel-lang/chapel/pull/21936.diff