[Chapel Merge] Re-enable counts (#) on ranges to take bool values

Notifications Commits
1

Branch: refs/heads/main
Revision: ebb761d
Author: bradcray
Link: Unavailable
Log Message:

Merge pull request #20111 from bradcray/count-any-integral

Re-enable counts (#) on ranges to take bool values

[reviewed by @lydia-duncan]

In #20098, I unwittingly disabled support for applying boolean count
values to ranges because 'integral' arguments don't accept booleans.
It turns out Arkouda relied on this (our testing system didn't), so
here I'm re-enabling it for the time being as it wasn't my intention
to change the behavior.

For me, there are a few questions here:

  • Should we continue to support boolean counts? (the alternative
    being to require the user to cast them to an integer)

  • Should integral formal types accept boolean actuals? Is it
    inconsistent that our previous implementation that accepted
    int(?w)/uint(?w) counts accepted bools when integral doesn't?

While here, I also removed some argument matching against index
types which I noticed was no longer used.

Modified Files:
A test/domains/operators/countByBool.chpl

A test/domains/operators/countByBool.good
A test/types/range/count/countWithBool.chpl
A test/types/range/count/countWithBool.good
M modules/internal/ChapelRange.chpl

Compare: https://github.com/chapel-lang/chapel/compare/264b91e39467...ebb761ded7da