[Chapel Merge] Post initializer conversion fixes

Branch: refs/heads/main
Revision: 5a2bf22
Author: lydia-duncan
Log Message:

Merge pull request #18558 from lydia-duncan/postInitializerConvFixes

Post initializer conversion fixes
[reviewed by @mppf]

When we originally adjusted module code to use initializers instead of constructors,
we made a list of a few things to come back to as potential clean up items. Most of
them don't seem to need adjustment, but there were a couple of references to
constructors and one extraneous this.complete() call that could be removed. Do
so and close that issue.

Resolves #9579

Updated the expected output of one test to use a prediff to hide line numbers
because it was sensitive to changes in the Shared module

Passed a full paratest with futures to ensure the removal of this.complete() in
the _shared initializer was definitely not needed.

Modified Files:
A test/functions/vass/return-type-function-failure.prediff

M modules/dists/BlockCycDist.chpl
M modules/dists/ReplicatedDist.chpl
M modules/internal/SharedObject.chpl
M test/functions/vass/return-type-function-failure.good

Compare: https://github.com/chapel-lang/chapel/compare/649a645933f5...5a2bf2232b52