Branch: refs/heads/master
Revision: 5b8ecb3
Author: bradcray
Log Message:
Merge pull request #17801 from bradcray/all-size-return-int
Make sure all '.size' methods return int
[trivial, not reviewed]
This is the result of a sweep I took to see that all 'size' methods
return integers. I found that most did, but that:
-
HashedDist had a (private) interface that called .size() on domains
and arrays rather than .sizeAs(), which would've resulted in a
warning if that code path is still used (it doesn't seem to be in our
testing). -
Some other cases didn't declare the return type of .size, so I
updated them to do so for the sake of documentation / sanity.
This leaves:
-
ranges, domains, and arrays which return various types depending on
whether one uses the sizeReturnsInt toggle (can be updated to return
intwhen we remove the old returnidxTypebehavior. -
.size() on BigInteger, which is different and being discussed in
[Library Stabilization] bigint size and sizeinbase questions · Issue #17693 · chapel-lang/chapel · GitHub
Resolves #17643
Modified Files:
M modules/dists/HashedDist.chpl
M modules/internal/Bytes.chpl
M modules/packages/EpochManager.chpl
M modules/standard/IO.chpl
Compare: https://github.com/chapel-lang/chapel/compare/4893c18e9d0c...5b8ecb3574e1