Branch: refs/heads/main
Revision: a577edd
Author: mppf
Link: Unavailable
Log Message:
Merge pull request #20122 from mppf/fix-param-inf
Improve param-inf test an param real to string casts
Adjust param-inf to avoid outputing negative nans and also adjusted param
real : string cast to use inf / nan instead of INFINITY / NAN to better
match regular output of these values.
We were observing failures for param-inf on an arm system due to
differences in whether or not the NANs were negative. But, a NAN being
positive or negative is not guaranteed by C/C++ (the param-evaluation is
happening in C++ code within the compiler) and Chapel isn't trying to do
anything special for the sign of NANs.
Resolves https://github.com/Cray/chapel-private/issues/3520
Reviewed by @ronawho - thanks!
-
full local testing
Modified Files:
M compiler/dyno/lib/immediates/num.cpp
M test/param/ferguson/param-inf.chpl
M test/param/ferguson/param-inf.goodCompare: Comparing 895760f0a545...a577edd8c5aa · chapel-lang/chapel · GitHub