Branch: refs/heads/master
Revision: 55e3488
Author: bradcray
Log Message:
Merge pull request #17746 from bradcray/avoid-int2idx-method
Fix some issues in chpl__serialViewIter
[reviewed by @e-kayrakli]
This addresses a few issues in this code that Engin pointed out in
https://github.com/Cray/chapel-private/issues/1904:
-
It gets away from calling dom.chpl_intToIdx() because we don't
want to have to provide this as a method on all non-DR domains -
Similarly, it changes away from using dom.intIdxType for similar
reasons.
Most uses of these routines in this file are fine (I believe) because
they're calling the local DR version of the routines. However, this
is a routine used across a lot of distinct domain map types, so it's
important that it use the standalone versions of the routines rather
than relying on the convenience methods.
Filed a test locking in Engin's original test and a second version of
it that I noticed would go down a different stridable path, revealing
new errors.
Resolves https://github.com/Cray/chapel-private/issues/1904
Modified Files:
A test/arrays/views/viewDomBug.chpl
A test/arrays/views/viewDomBug.good
M modules/internal/DefaultRectangular.chpl
Compare: https://github.com/chapel-lang/chapel/compare/d164e9cde7b5...55e3488a0101