[Chapel Merge] Fix race in copy-elision-control-flow

Branch: refs/heads/main
Revision: cb92c85
Author: mppf
Link: Fix race in copy-elision-control-flow by mppf · Pull Request #19414 · chapel-lang/chapel · GitHub
Log Message:

Merge pull request #19414 from mppf/fix-copy-elision-test-race

Fix race in copy-elision-control-flow

We were seeing some sporadic failures for the test.

types/records/copy-elision/copy-elision-control-flow.chpl

especially in linux32. Fortunately, I was able to reproduce and learn
that the test itself had a race where a deinit of a variable prints out
something after the sync variable signals to continue the rest of the
program.

This PR fixes the issue by adding a { } block around the code
introducing the variable which ensures that the deinit runs before the
sync variable is signalled.

Test change only - not reviewed.

Modified Files:
M test/types/records/copy-elision/copy-elision-control-flow.chpl

Compare: https://github.com/chapel-lang/chapel/compare/96341a8cdb69...cb92c85904d3