Branch: refs/heads/main
Revision: 9c28cd2
Author: bradcray
Link: Fix handling of non-zero exit status in mysystem() by bradcray · Pull Request #18729 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #18729 from bradcray/error-on-bad-make2
Fix handling of non-zero exit status in mysystem()
[reviewed by @mppf]
This fixes an issue introduced in PR #18594 in which mysystem()
no longer generates a user error if the forked off process
returned a non-zero exit code. An example impact of this is
that if 'make -f' failed, the compiler would generate a 0 exit
status and the test system would assume compilation succeeded
until it tried to run the resulting program, which wasn't there.
The fix is to have the parent process handle the non-zero exit
status prior to returning.
Resolves Cray/chapel-private#2725
Modified Files:
M compiler/util/mysystem.cpp
Compare: https://github.com/chapel-lang/chapel/compare/d36815f23ca6...9c28cd26a106