Branch: refs/heads/main
Revision: 348118e
Author: aconsroe-hpe
Link: Fix failing tests from tasks warning by aconsroe-hpe · Pull Request #19008 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19008 from aconsroe-hpe/fix/fifo-threads-limit-2
Fix failing tests from tasks warning
reviewed by @ronawho -- thanks for helping me sort this one out
Fixes tests broken by #18871
Extra newline caused whitespace diff failure (eg in multilocale/gasnet/bradc/257threads and studies/madness/aniruddha/madchap/test_diff)
ManyThreads was failing because it was not adequately prepared for testing in the matrix of combinations. I also prediff'd the hardware dependent limits to be able to test locally.
ManyThreads tested locally under the matrix comm={none,gasnet} x tasks={fifo,qthreads}
Quickstart and asan testing configurations have tasks=fifo, so we set the _QUIET env var to be the default. (ManyThreads does need to override this)
Modified Files:
A test/parallel/taskPool/figueroa/ManyThreads.comm-gasnet.tasks-fifo.good
A test/parallel/taskPool/figueroa/ManyThreads.comm-gasnet.tasks-qthreads.good
R test/parallel/taskPool/figueroa/ManyThreads.tasks-none.good
M runtime/src/tasks/qthreads/tasks-qthreads.c
M test/parallel/taskPool/figueroa/ManyThreads.comm-gasnet.good
M test/parallel/taskPool/figueroa/ManyThreads.execenv
M test/parallel/taskPool/figueroa/ManyThreads.prediff
M test/parallel/taskPool/figueroa/ManyThreads.tasks-qthreads.good
M util/cron/common-asan.bash
M util/cron/common-quickstart.bash
M util/test/sub_test.py
Compare: https://github.com/chapel-lang/chapel/compare/b45275f323b1...348118e941d8