[Chapel Merge] fix(chpldoc): fix future tests that were breaking

Notifications Commits
1

Branch: refs/heads/main
Revision: 43094d6
Author: arezaii
Link: Unavailable
Log Message:

Merge pull request #20605 from arezaii/fix-dyno-chpldoc-futures

fix(chpldoc): fix future tests that were breaking

This PR removes some .future and .bad files for chpldoc futures that
were resolved by dyno-chpldoc, and makes a few fixes to dyno-chpldoc
to emit error messages as some future .bad files expect them. It also
fixes a small bug where we would emit a message saying the docs were
in a directory even if the sphinx task failed.

Fix details:

  • after swapping to dyno-chpldoc, there were 6 future tests that
    were breaking. Three of these were futures on the operator keyword
    which was implemented in dyno-chpldoc. Those .future and .bad files
    were removed. The other three failures were due to bad error messages. Two
    were caused by only writing the first error and exiting, the last
    was caused by dyno-chpldoc writing an output message before checking
    the return status of the sphinx task.

TESTING:

  • paratest with futures
  • all chpldoc tests with futures

reviewed by @dlongnecke-cray - thanks!

Signed-off-by: arezaii ahmad.rezaii@hpe.com

Modified Files:
R test/chpldoc/functions/operatorPrimaryMethods.doc.bad

R test/chpldoc/functions/operatorPrimaryMethods.doc.future
R test/chpldoc/functions/operatorSecondaryMethods.doc.bad
R test/chpldoc/functions/operatorSecondaryMethods.doc.future
R test/chpldoc/functions/operators.doc.bad
R test/chpldoc/functions/operators.doc.future
M compiler/dyno/tools/chpldoc/chpldoc.cpp
M test/chpldoc/functions/operatorPrimaryMethods.doc.good
M test/chpldoc/functions/operatorSecondaryMethods.doc.good
M test/chpldoc/functions/operators.doc.good

Compare: https://github.com/chapel-lang/chapel/compare/3f0c25839001...43094d66ab5b