Branch: refs/heads/main
Revision: 0e8b99f
Author: dlongnecke-cray
Link: Fix bug in _ddata helper function added for `unsafeAssign()` by dlongnecke-cray · Pull Request #19245 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19245 from dlongnecke-cray/cron-fix-unsigned-mul-bug
Fix bug in _ddata helper function added for unsafeAssign()
In #18928 I added a helper function for _ddata
which takes a
_ddata
buffer and memsets it with a fill value. I did not realize
that the result of _ddata_sizeof_element()
is a signed integer.
This caused test failures on linux32
boxes.
Convert buffer size to uint
before using.
TESTING
- [x]
make && make check
onlinux64
,linux32
,darwin
- [x]
arrays, domains
onlinux64
withCOMM=none
Signed-off-by: David Longnecker dlongnecke-cray@users.noreply.github.com
Modified Files:
M modules/internal/ChapelBase.chpl
Compare: https://github.com/chapel-lang/chapel/compare/6a5769047551...0e8b99fc1cac