[Chapel Merge] Fix an assertion failure in scope resolve

Notifications Commits
1

Branch: refs/heads/main
Revision: bfe9d20
Author: mppf
Link: Fix an assertion failure in scope resolve by mppf · Pull Request #20252 · chapel-lang/chapel · GitHub
Log Message:

Merge pull request #20252 from mppf/follow-20228

Fix an assertion failure in scope resolve

Follow-up to PR #20228

PR #20228 changed the AST builders for ForLoop and LoopExpr to work with
indices of DefExpr. Along with that, it added more checking in scope
resolve, but this checking led to failures to compile Arkouda.

This PR addresses the failing case which gets Arkouda building again and
adds a simple test that shows the pattern that was not working.

Additionally, this PR fixes a few .bad files for error message
improvements from PR #20228.

Reviewed by @dlongnecke-cray - thanks!

  • full local testing

  • CHPL_TEST_ARKOUDA=true ./util/start_test test/studies/arkouda/ succeeds

    Modified Files:
    A test/users/ferguson/max-reduce-blank.chpl
    A test/users/ferguson/max-reduce-blank.good
    M compiler/passes/scopeResolve.cpp
    M test/classes/diten/subclassMethodCall.bad
    M test/classes/forwarding/promotionBug.bad
    M test/types/records/const-checking/postinit-of-const.bad

    Compare: Comparing da9319749012...bfe9d20d46a1 · chapel-lang/chapel · GitHub