Branch: refs/heads/main
Revision: 8dfa388
Author: arezaii
Link: dyno: update errors for bad import/use statements by arezaii · Pull Request #19710 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19710 from arezaii/dyno-import-use-as-test-fixes
dyno: update errors for bad import/use statements
This PR updates the handling of import and use statements
in the dyno parser to emit error messages that align with the
production compiler.
Previously, when building a VisibilityClause in dyno we did
not necessarily know if we were building the clause for a use
or an import statement, and therefore we could not emit the
correct error message when the clause was invalid. This change
adds a formal boolean to indicate if the clause is an import
and updates some of the error messages emitted when an invalid
syntax is recognized.
TESTING:
- [x] paratest
- [x] paratest with
--dyno(110 failures vs. 114 on main)
reviewed by @dlongnecke-cray - thank you!
Signed-off-by: arezaii ahmad.rezaii@hpe.com
Modified Files:
M compiler/dyno/lib/parsing/ParserContext.h
M compiler/dyno/lib/parsing/ParserContextImpl.h
M compiler/dyno/lib/parsing/bison-chpl-lib.cpp
M compiler/dyno/lib/parsing/chpl.ypp
Compare: https://github.com/chapel-lang/chapel/compare/9622358b3fe0...8dfa3883fdc5