Branch: refs/heads/main
Revision: f2e9ef7
Author: dlongnecke-cray
Link: dyno: More fixes for tests running under COMM=gasnet by dlongnecke-cray · Pull Request #19771 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #19771 from dlongnecke-cray/dyno-gasnet-llvm-none-parser-fixes
dyno: More fixes for tests running under COMM=gasnet (#19771)
A bunch of fixes which get more tests to pass with --dyno while
running with COMM=gasnet.
The most notable fix here is that we stop attaching qualified types
to variable-like things early. Attaching early doesn't affect any
tests when running under COMM=none. However, doing so when
running with wide pointers leads to strange runtime bugs that are
extremely difficult to debug.
My guess is that setting early affects some optimizations or shallow
copies that occur during resolution or in insertWideReferences().
I don't know for sure, though.
Future work should find this bug so that we can resume attaching
qualified types early.
[Summary: #Successes = 13573 | #Failures = 36 | #Futures = 0]
Signed-off-by: David Longnecker dlongnecke-cray@users.noreply.github.com
Reviewed by @arezaii. Thanks!
Modified Files:
M compiler/parser/parser.cpp
M compiler/passes/convert-uast.cpp
Compare: https://github.com/chapel-lang/chapel/compare/519d0c55b5cb...f2e9ef75b610