Branch: refs/heads/main
Revision: a3237af
Author: benharsh
Link: Unavailable
Log Message:
Merge pull request #20348 from benharsh/scope-resolve-fixes
dyno: misc. scope resolve fixes
This PR includes three distinct changes to convert-uast
that resolve some failures when scope-resolving the primers with --dyno
.
- Adds new cases to
convertScanReduceOp
for word-based scan/reduce operations (e.g. minmax) - Does not scope-resolve function calls - this needs to be handled by the production compiler's type resolution process
- Invokes
noteConvertedSym
when processing aTupleDecl
.
This PR also makes a small change to convertCalledKeyword
. Previously this function was resolving any identifier, rather than just keywords, and could result in some confusing situations. Removing this functionality does not result in any additional failures for the primers.
[reviewed-by @mppf]
Modified Files:
M compiler/dyno/include/chpl/framework/all-global-strings.h
M compiler/dyno/lib/resolution/Resolver.cpp
M compiler/passes/convert-uast.cpp
Compare: https://github.com/chapel-lang/chapel/compare/5ecd68ac9160...a3237af2e178