Branch: refs/heads/main
Revision: 6822207
Author: bmcdonald3
Link: Unavailable
Log Message:
Merge pull request #18796 from bmcdonald3/set-deprecate
Deprecate set.isIntersecting() and add ! case to deprecation filtering
[ reviewed by @lydia-duncan - thanks! ]
The same behavior of set.isIntersecting() can be achieved through !set.isDisjoint(), so the extra method seems extraneous. Additionally, there isn't much of a precedents for this method in other languages, and the ing naming is something that is fairly unique to this method in the Chapel codebase, so we have chosen to deprecate it. This PR also adds the ability to lead a symbol with ! in the deprecation warning. The need for this was found with the original message that was being used for deprecation, but that message was changed, so this functionality isn't used in this PR, but it was still included to not lose that additional feature.
Modified Files:
A test/deprecated/Set/setIsIntersecting.chpl
A test/deprecated/Set/setIsIntersecting.good
R test/library/standard/Set/isIntersecting/setIsIntersecting.chpl
R test/library/standard/Set/isIntersecting/setIsIntersecting.good
M compiler/AST/symbol.cpp
M modules/standard/Set.chpl
M test/deprecated-keyword/messageFiltering.chpl
M test/deprecated-keyword/messageFiltering.good
Compare: https://github.com/chapel-lang/chapel/compare/859cc4dd4db8...6822207310eb