[Chapel Merge] break(Version): stop printing "version " when cast

arezaii · September 27, 2022, 3:06pm

Branch: refs/heads/main
Revision: 95780b3
Author: arezaii
Link: break(Version): stop printing "version " when casting sourceVersion by arezaii · Pull Request #20415 · chapel-lang/chapel · GitHub
Log Message:

Merge pull request #20415 from arezaii/dont-print-version

break(Version): stop printing "version " when casting sourceVersion

This PR changes the behavior when casting a sourceVersion to
string. After this PR, we will no longer append version to
the major.minor.update (commit) format.

Marked as potentially breaking if you were previously relying
on version being in the result of a cast from a sourceVersion,
including chplVersion.

change the behavior when casting a sourceVersion to string to
no longer prepend the word "version " to the resulting string.
This change was discussed in
Should `sourceVersion` continue to prepend `version ` when cast to string? · Issue #19928 · chapel-lang/chapel · GitHub
update tests to no longer expect "version " in most cases

TESTING:

paratest
manual review of Version docs

reviewed by @bradcray - thank you!

Signed-off-by: arezaii ahmad.rezaii@hpe.com

Modified Files:
M modules/standard/Version.chpl

M test/library/standard/Version/compareChplVersion.good
M test/library/standard/Version/compareChplVersionErrors.good
M test/library/standard/Version/testChplVersion.chpl
M test/library/standard/Version/versionCastIsParam.chpl
M test/library/standard/Version/versionCastIsParam.good

Compare: https://github.com/chapel-lang/chapel/compare/0cce54a2f256...95780b33212e