Branch: refs/heads/main
Revision: bdcbc83
Author: lydia-duncan
Link: Unavailable
Log Message:
Merge pull request #18807 from tiger-yash/tiger-2
bigint.remove() renamed to bigint.removeFactor(), and other cleanups to the function
[contributed by @tiger-yash, reviewed by Lydia]
This PR closes #17732
Description
- Changed the function name
- Renames the arguments to x and fac
- Added the required Deprecation Warning test.
- Added a test for when the factor is 0 and adjusted the result to avoid a floating point failure
Passed a full paratest with futures, and the built documentation looks good
Modified Files:
A test/deprecated/BigInteger/deprecateRemove.chpl
A test/deprecated/BigInteger/deprecateRemove.good
A test/library/standard/GMP/removeFactorCheck.chpl
A test/library/standard/GMP/removeFactorCheck.good
M modules/standard/BigInteger.chpl
M test/library/standard/GMP/ldelaney/gmp_Bigint_number_theoretic.chpl
Compare: https://github.com/chapel-lang/chapel/compare/a09fcb4a8361...bdcbc831363e