Branch: refs/heads/main
Revision: a22ca3a
Author: mppf
Link: Allow iterating over range counted by bool & test it by mppf · Pull Request #20602 · chapel-lang/chapel · GitHub
Log Message:
Merge pull request #20602 from mppf/allow-iterating-counted-by-bool
Allow iterating over range counted by bool & test it
This is to fix a problem building Arkouda after PR #20595.
It is not so clear to me that it makes sense to have a bool
count, but
since bool
can coerce to an integer type, it seems OK. Before PR
#20528, the count arguments were matching the low bound type, but that PR
changed them to integral
to match other choices about counting.
However, count:integral
arguments cannot currently accept a bool
(but
issue #20011 requests that they could). Since the helper code will cast
them appropriately, this PR just removes the type constraint.
- test/types/range/elliot passes with CHPL_LLVM=none
- Arkouda builds
- full local testing
Reviewed by @benharsh and @bradcray - thanks!
Modified Files:
A test/types/range/nonIntTypes/countedByBool.chpl
A test/types/range/nonIntTypes/countedByBool.good
M modules/internal/ChapelRange.chpl
Compare: https://github.com/chapel-lang/chapel/compare/92bb7e21064c...a22ca3a78b10