[Chapel Merge] Adjust 'unsafeAssignManager.initialize()' method t

Notifications Commits
1

Branch: refs/heads/main
Revision: 5fb9827
Author: dlongnecke-cray
Link: Adjust 'unsafeAssignManager.initialize()' method to halt by dlongnecke-cray · Pull Request #19485 · chapel-lang/chapel · GitHub
Log Message:

Merge pull request #19485 from dlongnecke-cray/unsafe-assign-adjust-initialize

Adjust 'unsafeAssignManager.initialize()' method to halt (#19485)

While reviewing the docs for the new domain.unsafeAssign() method,
I saw a TODO I had left to consider making the initialize()
method on the manager halt if checks == true and an already
initialized slot was initialized again. I decided to make that change
in this PR, along with updating the docs for the method.

I think this is the correct thing to do for now because it is more
strict (we can always revert this decision later, but cannot go in
the other direction without breaking changes).

TESTING

  • [x] ALL on linux64 when COMM=none
  • [x] Updated docs checked locally

Reviewed by @vasslitvinov. Thanks!

Signed-off-by: David Longnecker dlongnecke-cray@users.noreply.github.com

Modified Files:
A test/domains/unsafeAssign/HaltChecksDuplicateInit.chpl

A test/domains/unsafeAssign/HaltChecksDuplicateInit.good
M modules/internal/ChapelDomain.chpl

Compare: https://github.com/chapel-lang/chapel/compare/7382b72bfa93...5fb9827eb8dd