[Chapel Merge] Adjust find-llvm-config.sh to also check for heade

Notifications Commits
1

Branch: refs/heads/master
Revision: 14d2890
Author: mppf
Log Message:

Merge pull request #17793 from mppf/add-check-for-llvm-header

Adjust find-llvm-config.sh to also check for header

With LLVM becoming the default backend we need to take more care to make
sure it is detected appropriately and that helpful error messages are
shown if something isn't right. One common error is to install llvm and
clang but not versions of these packages that include the header files.
(On Ubuntu, these are llvm-11-dev and libclang-11-dev). Before this
PR, we would auto-detect that a system LLVM was available and then run
into errors during compilation.

This PR changes find-llvm-config.sh to not consider it a "found" LLVM
configuration if an LLVM header and a clang header are not available.

  • [x] checked that the expected error appears when removing llvm-11-dev
    and libclang-11-dev on an Ubuntu system
  • [x] full local testing

Reviewed by @daviditen - thanks!

Modified Files:
M third-party/llvm/find-llvm-config.sh

Compare: https://github.com/chapel-lang/chapel/compare/7e976a3c2bad...14d28909e9b2