[Chapel Merge] Adjust checkGenericFormals to always do type-indep

Branch: refs/heads/master
Revision: a328e97
Author: mppf
Log Message:

Merge pull request #16491 from mppf/issue-16478

Adjust checkGenericFormals to always do type-independent checks

Resolves #16478

Follow-up to #16479

This PR adjusts checkGenericFormals to do the type-independent checks
outside of the check for the argument type being established.
Additionally it addresses a redundancy identified in the review of #16479.

Reviewed by @vasslitvinov - thanks!

  • [x] full local futures testing

Modified Files:
R test/functions/resolution/error-expected-param-missing2.bad
R test/functions/resolution/error-expected-param-missing2.future
M compiler/AST/FnSymbol.cpp
M compiler/resolution/ResolutionCandidate.cpp
M test/functions/resolution/error-expected-param-missing2.good

Compare: https://github.com/chapel-lang/chapel/compare/8c13d1c724c4...a328e979b8ef